Skip to content

Rename frameworks experiment to internalframeworks to avoid confusion. #6439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Rename frameworks experiment to internalframeworks to avoid confusion. #6439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29ef884
Rename frameworks experiment to internalframeworks to avoid confusion.
taeold Oct 10, 2023
b4e9548
Missed a spot.
taeold Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/commands/init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ const choices = [
},
];

if (isEnabled("frameworks")) {
if (isEnabled("internalframeworks")) {
choices.push({
value: "frameworks",
value: "internalframeworks",
name: "Frameworks: Get started with Frameworks projects.",
checked: false,
});
Expand All @@ -85,7 +85,7 @@ const featureNames = choices.map((choice) => choice.value);

const DESCRIPTION = `Interactively configure the current directory as a Firebase project or initialize new features in an already configured Firebase project directory.

This command will create or update 'firebase.json' and '.firebaserc' configuration files in the current directory.
This command will create or update 'firebase.json' and '.firebaserc' configuration files in the current directory.

To initialize a specific Firebase feature, run 'firebase init [feature]'. Valid features are:
${[...featureNames]
Expand Down
2 changes: 1 addition & 1 deletion src/experiments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export const ALL_EXPERIMENTS = experiments({
"without a notice.",
},

frameworks: {
internalframeworks: {
shortDescription: "Allow CLI option for Frameworks",
default: true,
public: false,
Expand Down
4 changes: 2 additions & 2 deletions src/init/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ const featureFns = new Map<string, (setup: any, config: any, options?: any) => P
["hosting:github", features.hostingGithub],
]);

if (isEnabled("frameworks")) {
featureFns.set("frameworks", features.frameworks);
if (isEnabled("internalframeworks")) {
featureFns.set("internalframeworks", features.frameworks);
}

export async function init(setup: Setup, config: any, options: any): Promise<any> {
Expand Down