Skip to content

add nuxt init method for firebase hosting #6309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 7, 2023
Merged

add nuxt init method for firebase hosting #6309

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e79d7ba
add nuxt init method for firebase init hosting
JulienMartel Aug 29, 2023
e4e6a63
Merge branch 'master' into nuxt-init-hosting
leoortizz Dec 7, 2023
c7fa611
Changelog, supportedRange, and address feedback
jamesdaniels Dec 7, 2023
9098054
Merge branch 'master' into nuxt-init-hosting
jamesdaniels Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changelog, supportedRange, and address feedback
  • Loading branch information
@jamesdaniels
jamesdaniels committed Dec 7, 2023
commit c7fa611b70a8782ef08aca8753cb3d25d974b67d
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@
- Warn if a Web Framework is outside a well known version range on deploy/emulate. (#6562)
- Use Web Framework's well known version range in `firebase init hosting`. (#6562)
- Limit Web Framework's generated Cloud Function name to 23 characters, fixing deploys for some. (#6260)
- Allow Nuxt as an option during `firebase init hosting`. (#6309)
10 changes: 4 additions & 6 deletions src/frameworks/nuxt/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,9 @@ export async function getConfig(dir: string): Promise<NuxtOptions> {
* Utility method used during project initialization.
*/
export function init(setup: any, config: any) {
return new Promise<void>((resolve) => {
execSync(`npx --yes nuxi@latest init ${setup.hosting.source}`, {
stdio: "inherit",
cwd: config.projectDir,
});
resolve();
execSync(`npx --yes nuxi@"${supportedRange}" init ${setup.hosting.source}`, {
stdio: "inherit",
cwd: config.projectDir,
});
return Promise.resolve();
}