Skip to content

fix npm root issues on Next.js deploy #6372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2023
Merged

fix npm root issues on Next.js deploy #6372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a3c5a3
increase npm root timeout to 5s
leoortizz Sep 18, 2023
fb11ddc
memoize npm root
leoortizz Sep 18, 2023
2eb65fe
changelog
leoortizz Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix "Could not find the next executable" on Next.js deployments (#6372)
15 changes: 13 additions & 2 deletions src/frameworks/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ import { BUILD_TARGET_PURPOSE, RequestHandler } from "./interfaces";
// the import statement into a require
const { dynamicImport } = require(true && "../dynamicImport");

const NPM_ROOT_TIMEOUT_MILLIES = 2_000;
const NPM_ROOT_TIMEOUT_MILLIES = 5_000;
const NPM_ROOT_MEMO = new Map<string, string>();

/**
* Whether the given string starts with http:// or https://
Expand Down Expand Up @@ -222,9 +223,19 @@ function scanDependencyTree(searchingFor: string, dependencies = {}): any {
}

export function getNpmRoot(cwd: string) {
return spawnSync("npm", ["root"], { cwd, timeout: NPM_ROOT_TIMEOUT_MILLIES })
let npmRoot = NPM_ROOT_MEMO.get(cwd);
if (npmRoot) return npmRoot;

npmRoot = spawnSync("npm", ["root"], {
cwd,
timeout: NPM_ROOT_TIMEOUT_MILLIES,
})
.stdout?.toString()
.trim();

NPM_ROOT_MEMO.set(cwd, npmRoot);

return npmRoot;
}

export function getNodeModuleBin(name: string, cwd: string) {
Expand Down