-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix issue with mixed v1 and v2 functions deployments #6293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehan
approved these changes
Aug 23, 2023
blidd-google
added a commit
that referenced
this pull request
Aug 24, 2023
This reverts commit d44e236.
joehan
pushed a commit
that referenced
this pull request
Aug 24, 2023
JulienMartel
pushed a commit
to monogramdesign/firebase-tools
that referenced
this pull request
Aug 25, 2023
* fix source token scraper issue
JulienMartel
pushed a commit
to monogramdesign/firebase-tools
that referenced
this pull request
Aug 25, 2023
…e#6293)" (firebase#6295) This reverts commit d44e236.
The recent changes to enable single builds inadvertently broke mixed v1 / v2 function deploys. The issue was caused by the deploy logic trying to use the source token from a v1 image to create a v2 function, and vice versa.
Fixes #6290.