Skip to content

Next.js image optimization fixes #6143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 19, 2023
Merged

Next.js image optimization fixes #6143

merged 16 commits into from
Jul 19, 2023

Conversation

leoortizz
Copy link
Member

@leoortizz leoortizz commented Jul 17, 2023 •
edited
Loading

Description

Scenarios Tested

Sample Commands

@leoortizz leoortizz requested a review from alexastrum July 17, 2023 19:10
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023 •
edited
Loading

Codecov Report

Patch coverage: 76.00% and project coverage change: +0.03 🎉

Comparison is base (83c5292) 54.58% compared to head (807588d) 54.62%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6143      +/-   ##
==========================================
+ Coverage   54.58%   54.62%   +0.03%     
==========================================
  Files         346      346              
  Lines       23630    23644      +14     
  Branches     4862     4864       +2     
==========================================
+ Hits        12899    12915      +16     
+ Misses       9547     9545       -2     
  Partials     1184     1184
Impacted Files Coverage Δ
src/frameworks/next/index.ts 14.06% <0.00%> (+0.10%) ⬆️
src/frameworks/next/utils.ts 88.03% <82.60%> (-0.09%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

alexastrum
alexastrum requested changes Jul 17, 2023
View reviewed changes
@leoortizz leoortizz requested a review from alexastrum July 18, 2023 01:27
@alexastrum alexastrum enabled auto-merge (squash) July 19, 2023 13:25
@alexastrum alexastrum merged commit ad4e144 into master Jul 19, 2023
@leoortizz leoortizz deleted the leoortizz_nextImageOptimizationFixes branch July 19, 2023 15:11
@marlier marlier mentioned this pull request Aug 16, 2023
Closed
joehan added a commit that referenced this pull request Dec 14, 2023
@joehan @christhompsongoogle
@chalosalvador @hsubox76 @svnsairam @clairekeer1997 @jiayou97 @taeold @tonyjhuang @inlined @alexastrum @blidd-google @google-oss-bot