Skip to content

[Fix] Astro relatives dirs #5709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Dec 7, 2023
Merged

[Fix] Astro relatives dirs #5709

merged 17 commits into from
Dec 7, 2023

Conversation

Geoffrey-Pliez
Copy link
Contributor

Description

Fix a problem in relative paths

Indeed, the paths retrieved in the astro config begin with file:/// and the pathname begins with '/' so the relative function returns a bad value.

This generates an error in the build.

scenario

launch firebase deploy on Windows

@Geoffrey-Pliez Geoffrey-Pliez changed the title [Fix] relatives dirs [Fix] Astro relatives dirs Apr 19, 2023
jamesdaniels
jamesdaniels reviewed Apr 19, 2023
View reviewed changes
Copy link
Member

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, I missed testing on Windows

@jamesdaniels
Copy link
Member

I'll add changelog and merge shortly

@Geoffrey-Pliez
Copy link
Contributor Author

Hi @jamesdaniels
Don't forget to approve and merge this fix.
Thanks in advance. ;)

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.29%. Comparing base (9fd1102) to head (bc45244).
Report is 564 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5709   +/-   ##
=======================================
  Coverage   54.29%   54.29%           
=======================================
  Files         347      347           
  Lines       24034    24035    +1     
  Branches     4960     4960           
=======================================
+ Hits        13049    13050    +1     
  Misses       9788     9788           
  Partials     1197     1197

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Geoffrey-Pliez Geoffrey-Pliez mentioned this pull request Oct 19, 2023
Merged
@Geoffrey-Pliez
Copy link
Contributor Author

Hi @jamesdaniels
I found a cross-platform solution with my latest commit ;)

@jamesdaniels jamesdaniels enabled auto-merge (squash) December 7, 2023 16:39
@jamesdaniels jamesdaniels merged commit ed13fde into firebase:master Dec 7, 2023
joehan added a commit that referenced this pull request Dec 14, 2023
@joehan @christhompsongoogle
@chalosalvador @hsubox76 @svnsairam @clairekeer1997 @jiayou97 @taeold @tonyjhuang @inlined @alexastrum @blidd-google @google-oss-bot @apascal07 @pavelgj @dominicbartl @aalej @fredzqm @egilmorez @dependabot @michaelprichardson @VicVer09