Skip to content

Add 4GB as a valid memory option for the functions emulator #3026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 15, 2021
Merged

Add 4GB as a valid memory option for the functions emulator #3026

merged 7 commits into from
Jan 15, 2021

Conversation

joehan
Copy link
Contributor

@joehan joehan commented Jan 12, 2021

Description

Adds 4GB as a valid memory option for the Functions Emulator, to match firebase/firebase-functions#842.

Scenarios Tested

Tested emulating a function with availableMemoryMb="4GB".

@joehan joehan requested a review from samtstern January 12, 2021 22:28
@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Jan 12, 2021
@joehan joehan mentioned this pull request Jan 12, 2021
Merged
@coveralls
Copy link

coveralls commented Jan 12, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 65.538% when pulling 23005ff on jh-4gb-emu into 933ef1b on master.