Skip to content

Add 4GB as a valid memory option for the functions emulator #3026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 15, 2021
Merged

Add 4GB as a valid memory option for the functions emulator #3026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
144907b
add 4GB as a valid memory option
joehan Jan 12, 2021
64f414f
Merge branch 'master' into jh-4gb-emu
joehan Jan 12, 2021
8c6f9e9
Merge branch 'master' into jh-4gb-emu
joehan Jan 14, 2021
59505f6
adding changelog
joehan Jan 14, 2021
23005ff
Merge branch 'master' into jh-4gb-emu
joehan Jan 14, 2021
3797389
Merge branch 'master' into jh-4gb-emu
joehan Jan 15, 2021
804e311
Merge branch 'master' into jh-4gb-emu
joehan Jan 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
- Catches errors while updating authorized domains when deleting channels, printing a warning instead of failing.
- Fixes issue where `host` header was being incorrectly set when proxying to Cloud Run or Cloud Functions for Firebase from the Hosting emulator. (#3012)
- Adds support for setting availableMemoryMb to 4GB in the Cloud Functions for Firebase emulator. (#3026)
- Fixes issue where emulated HTTP functions would crash when the URL contained query parameters (#3032)
- Fixes issue with routing to emulated HTTP functions in regions outside of `us-central1` (#3031)
- Fixes issue where authorized domains were not being correctly updated when deploying to Hosting channels. (#3002)
Expand Down
3 changes: 2 additions & 1 deletion src/emulator/functionsEmulatorShared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface EmulatedTriggerDefinition {
name: string;
timeout?: string | number; // Can be "3s" for some reason lol
regions?: string[];
availableMemoryMb?: "128MB" | "256MB" | "512MB" | "1GB" | "2GB";
availableMemoryMb?: "128MB" | "256MB" | "512MB" | "1GB" | "2GB" | "4GB";
httpsTrigger?: any;
eventTrigger?: EventTrigger;
schedule?: EventSchedule;
Expand Down Expand Up @@ -86,6 +86,7 @@ const memoryLookup = {
"512MB": 512,
"1GB": 1024,
"2GB": 2048,
"4GB": 4096,
};

export class HttpConstants {
Expand Down