Skip to content

Expose MultiDB API for Public Preview #7356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 16, 2023
Merged

Expose MultiDB API for Public Preview #7356

merged 6 commits into from
Jun 16, 2023

Conversation

tom-andersen
Copy link
Contributor

No description provided.

@tom-andersen tom-andersen requested review from a team as code owners June 7, 2023 18:01
@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 468e03c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Minor
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tom-andersen tom-andersen requested a review from wu-hui June 7, 2023 18:07
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 7, 2023 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (195f526)Merge (7a46bd0)Diff
    browser170 kB171 kB+53 B (+0.0%)
    cordova198 kB198 kB-5 B (-0.0%)
    esm5223 kB223 kB+53 B (+0.0%)
    main167 kB168 kB+53 B (+0.0%)
    module170 kB171 kB+53 B (+0.0%)
    react-native183 kB183 kB-5 B (-0.0%)

  • @firebase/auth/cordova

    TypeBase (195f526)Merge (7a46bd0)Diff
    browser198 kB198 kB-5 B (-0.0%)
    module198 kB198 kB-5 B (-0.0%)

  • @firebase/auth/internal

    TypeBase (195f526)Merge (7a46bd0)Diff
    browser181 kB181 kB+53 B (+0.0%)
    esm5237 kB237 kB+53 B (+0.0%)
    main204 kB204 kB+53 B (+0.0%)
    module181 kB181 kB+53 B (+0.0%)

  • @firebase/auth/react-native

    TypeBase (195f526)Merge (7a46bd0)Diff
    browser183 kB183 kB-5 B (-0.0%)
    module183 kB183 kB-5 B (-0.0%)

  • firebase

    TypeBase (195f526)Merge (7a46bd0)Diff
    firebase-auth-compat.js132 kB132 kB-5 B (-0.0%)
    firebase-auth-cordova.js147 kB147 kB-5 B (-0.0%)
    firebase-auth-react-native.js160 kB160 kB-5 B (-0.0%)
    firebase-auth.js127 kB127 kB+50 B (+0.0%)
    firebase-compat.js773 kB773 kB-5 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AatGnrgpej.html

@github-actions github-actions bot requested review from a team, dwyfrequency and hsubox76 as code owners June 7, 2023 18:32
@wu-hui wu-hui assigned tom-andersen and unassigned wu-hui Jun 7, 2023
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 7, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • TotpMultiFactorGenerator

      Size

      TypeBase (195f526)Merge (7a46bd0)Diff
      size37.5 kB37.6 kB+54 B (+0.1%)
      size-with-ext-deps58.3 kB58.4 kB+54 B (+0.1%)

    • multiFactor

      Size

      TypeBase (195f526)Merge (7a46bd0)Diff
      size37.3 kB37.3 kB-5 B (-0.0%)
      size-with-ext-deps58.1 kB58.1 kB-5 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/37aNPHhAB6.html

@tom-andersen tom-andersen requested a review from wu-hui June 9, 2023 15:50
@tom-andersen
Copy link
Contributor Author

@markarndt Could you have a quick look at this PR?

markarndt
markarndt approved these changes Jun 14, 2023
View reviewed changes
docs-devsite/firestore_.md Outdated
| Parameter | Type | Description |
| --- | --- | --- |
| app | [FirebaseApp](./app.firebaseapp.md#firebaseapp_interface) | The [FirebaseApp](./app.firebaseapp.md#firebaseapp_interface) instance that the returned [Firestore](./firestore_.firestore.md#firestore_class) instance is associated with. |
| databaseId | string | The name of database. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a "the": "The name of the database."

Fix here and in all occurences.

@tom-andersen tom-andersen merged commit 59c7b58 into master Jun 16, 2023
@tom-andersen tom-andersen deleted the tomandersen/multiDbPublicPreview branch June 16, 2023 20:38
@google-oss-bot google-oss-bot mentioned this pull request Jun 20, 2023
Merged
@hsubox76 hsubox76 mentioned this pull request Jun 20, 2023
Merged