Skip to content

Firestore: Bump the version of webchannel-wrapper so that it gets released #7311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2023
Merged

Firestore: Bump the version of webchannel-wrapper so that it gets released #7311

merged 2 commits into from
May 22, 2023

Conversation

dconeybe
Copy link
Contributor

In #7176 the new Firestore setting experimentalLongPollingOptions.timeoutSeconds was implemented; however, that PR forgot to mark @firestore/webchannel-wrapper as needing a new release and, therefore, the upgraded google-closure-library dependency was not picked up in the v9.22.0 release. As a result, setting experimentalLongPollingOptions.timeoutSeconds in that version has no effect. This PR bumps the version of webchannel-wrapper so it will get released with the upgraded google-closure-library dependency that implements the long polling timeout feature.

Fixes: #6987

@dconeybe
Bump the version of webchannel-wrapper so that it will get released w…
8fa59b9 
…ith the upgraded version of google-closure-library needed for the new `experimentalLongPollingOptions.timeoutSeconds` setting.
@dconeybe dconeybe requested a review from a team as a code owner May 20, 2023 05:04
@dconeybe dconeybe self-assigned this May 20, 2023
@dconeybe dconeybe requested review from a team as code owners May 20, 2023 05:04
@changeset-bot
Copy link

changeset-bot bot commented May 20, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: b0c205a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@firebase/webchannel-wrapper Patch
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dconeybe dconeybe mentioned this pull request May 20, 2023
Closed
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 20, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (8421ba1) and merge commit (e141898).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gNdPlWOvi9.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 20, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (8421ba1) and merge commit (e141898).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/pZuxlHBZhT.html

dwyfrequency
dwyfrequency approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit 23581c5 into master May 22, 2023
@hsubox76