Firestore: Enable auto-detection of long-polling networking mode #7236
Conversation
🦋 Changeset detectedLatest commit: e58f70b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… that its default value is now true
| @@ -88,8 +88,11 @@ export interface FirestoreSettings extends LiteSettings { | |||
| * detect if long-polling should be used. This is very similar to | |||
| * `experimentalForceLongPolling`, but only uses long-polling if required. | |||
| * | |||
| * This setting will likely be enabled by default in future releases and | |||
| * cannot be combined with `experimentalForceLongPolling`. | |||
| * After having had a default value of `false` since its inception 4 years | |||
There was a problem hiding this comment.
Note to self: update this documentation immediately after release to mention the year "2019" instead of "4 years ago" and the actual version number instead of "the most recent release".
There was a problem hiding this comment.
Googlers see b/278957890 for details.
There was a problem hiding this comment.
Suggestion: Just say "since 2019" and say "and changed in mid 2023" so you don't need to worry about it later?
There was a problem hiding this comment.
Done. I still think I want to go back and change it to the specific version and release date so that customers can more easily correlate their issues with the release. But at least with your wording suggestion it's not as time-critical to get that change in.
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
|
Firestore has a setting named
experimentalAutoDetectLongPollingwhich can be set totrueto enable some heuristics to detect if enabling "long-polling" networking mode fixes communication problems with the Firestore backend servers. See #1674 for details.For the past 4 years this "auto-detect" mode was opt-in; however, we now have confidence that it is safe to enable for everyone. Therefore, this PR enables the "auto-detect" mode by default. If you are experiencing networking issues you can try disabling the long-polling auto-detection by setting
FirestoreSettings.experimentalAutoDetectLongPollingtofalse. If you do this, please open an issue in this GitHub repository to report your problems and mention "long-polling" in the issue title.