Skip to content

Upgrade TypeScript to 4.7.4 #6682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Oct 17, 2022
Merged

Upgrade TypeScript to 4.7.4 #6682

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
2003cab
Fix prune-dts and bump typescript to 4.4
hsubox76 Oct 11, 2022
d8b6036
Bump to 4.7, clean up
hsubox76 Oct 11, 2022
6f260b4
Bump to 4.7
hsubox76 Oct 11, 2022
1143c67
Bump to 4.7.4
hsubox76 Oct 11, 2022
ef9e2c3
Bump related deps
hsubox76 Oct 11, 2022
2a1d0a7
formatting pass
hsubox76 Oct 11, 2022
05e0fd7
Fix create-overloads
hsubox76 Oct 12, 2022
47729e9
update deprecated methods in create-overloads
hsubox76 Oct 12, 2022
e7e619b
update deprecate methods in prune-dts
hsubox76 Oct 12, 2022
3063894
update yarn.lock
hsubox76 Oct 12, 2022
b01e94f
formatting pass
hsubox76 Oct 12, 2022
290fb20
trigger CI
hsubox76 Oct 13, 2022
6099588
Update API reports
hsubox76 Oct 12, 2022
588e745
Use createNotEmittedStatement
hsubox76 Oct 13, 2022
a7c81d8
Update changesets deprecated option
hsubox76 Oct 13, 2022
27918b1
Update API reports
hsubox76 Oct 13, 2022
1fba9c8
Add changeset
hsubox76 Oct 13, 2022
a12e121
Add changeset
hsubox76 Oct 13, 2022
4b94d34
Correctly check for declarations property
hsubox76 Oct 13, 2022
c51775d
formatting pass
hsubox76 Oct 13, 2022
b4f8313
Fix some TS in workspace.ts
hsubox76 Oct 13, 2022
4de31e0
formatting pass
hsubox76 Oct 14, 2022
baa8f8e
Merge branch 'master' into ch-ts-upgrade
hsubox76 Oct 17, 2022
27cd429
bump firebase version
hsubox76 Oct 17, 2022
915f8df
update yarn.lock
hsubox76 Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update deprecated methods in create-overloads
  • Loading branch information
@hsubox76
hsubox76 committed Oct 14, 2022
commit 47729e91a73813139b68fbf8c4ec448cf6e6be86
47 changes: 25 additions & 22 deletions scripts/build/create-overloads.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ function keepPublicFunctionsTransformer(
return (sourceFile: ts.SourceFile) => {
const typeChecker = program.getTypeChecker();
const overloads: ts.Statement[] = [];
const { factory } = context;
function visit(node: ts.Node): ts.Node {
if (ts.isFunctionDeclaration(node)) {
// return early if the function doesn't have any parameter of the type we are looking for
Expand All @@ -137,7 +138,7 @@ function keepPublicFunctionsTransformer(
return false;
})
) {
return ts.createToken(ts.SyntaxKind.WhitespaceTrivia);
return factory.createEmptyStatement();
}

const newParameters = node.parameters.map(param => {
Expand All @@ -146,14 +147,14 @@ function keepPublicFunctionsTransformer(
if (
param.type.typeName.getText(sourceFile) === replaceOption.match
) {
return ts.updateParameter(
return factory.updateParameterDeclaration(
param,
param.decorators,
param.modifiers,
param.dotDotDotToken,
param.name,
param.questionToken,
ts.createTypeReferenceNode(
factory.createTypeReferenceNode(
replaceOption.replacement,
param.type.typeArguments
),
Expand All @@ -173,7 +174,7 @@ function keepPublicFunctionsTransformer(
});

overloads.push(
ts.updateFunctionDeclaration(
factory.updateFunctionDeclaration(
node,
node.decorators,
[],
Expand All @@ -189,7 +190,7 @@ function keepPublicFunctionsTransformer(

// remove all nodes other than the source file itself
if (!ts.isSourceFile(node)) {
return ts.createToken(ts.SyntaxKind.WhitespaceTrivia);
return factory.createEmptyStatement();
}

return node;
Expand All @@ -214,43 +215,45 @@ function keepPublicFunctionsTransformer(
}

// hardcode adding `import { FirebaseApp as FirebaseAppCompat } from '@firebase/app-compat'`
const appCompatImport = ts.createImportDeclaration(
const appCompatImport = factory.createImportDeclaration(
undefined,
undefined,
ts.createImportClause(
factory.createImportClause(
false,
undefined,
ts.createNamedImports([
ts.createImportSpecifier(
factory.createNamedImports([
factory.createImportSpecifier(
false,
ts.createIdentifier('FirebaseApp'),
ts.createIdentifier('FirebaseAppCompat')
factory.createIdentifier('FirebaseApp'),
factory.createIdentifier('FirebaseAppCompat')
)
])
),
ts.createLiteral('@firebase/app-compat')
factory.createStringLiteral('@firebase/app-compat')
);

const importStatement = ts.createImportDeclaration(
const importStatement = factory.createImportDeclaration(
undefined,
undefined,
ts.createImportClause(
factory.createImportClause(
false,
undefined,
ts.createNamedImports(
factory.createNamedImports(
Array.from(typesToImport).map(typeName =>
ts.createImportSpecifier(true, undefined, ts.createIdentifier(typeName))
factory.createImportSpecifier(true, undefined, factory.createIdentifier(typeName))
)
)
),
ts.createLiteral(moduleNameToEnhance)
factory.createStringLiteral(moduleNameToEnhance)
);
const moduleToEnhance = ts.createModuleDeclaration(
const moduleToEnhance = factory.createModuleDeclaration(
undefined,
[ts.createModifier(ts.SyntaxKind.DeclareKeyword)],
ts.createStringLiteral(moduleNameToEnhance),
ts.createModuleBlock(overloads)
[factory.createModifier(ts.SyntaxKind.DeclareKeyword)],
factory.createStringLiteral(moduleNameToEnhance),
factory.createModuleBlock(overloads)
);

return ts.updateSourceFileNode(transformed, [
return factory.updateSourceFile(transformed, [
appCompatImport,
importStatement,
moduleToEnhance
Expand Down