Skip to content

Upgrade TypeScript to 4.7.4 #6682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Oct 17, 2022
Merged

Upgrade TypeScript to 4.7.4 #6682

merged 25 commits into from
Oct 17, 2022

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Oct 11, 2022 •
edited
Loading

We need to upgrade our TypeScript version, it's still at 4.2.2 and the latest is 4.8.4. We are going to try for a little behind the latest version, because some of our other deps have dependencies on TypeScript and may lag a little on which version they support. So we'll try for 4.7.4, the last 4.7.* release.

Most of the necessary updates (e.g. adding types to caught errors) have already been done by @dwyfrequency in previous PRs.

The most notable fix here is that TypeScript 4.3 introduced the ability for TS to recognize {@link statements in comments, which caused it to break up comments into multiple nodes which caused some assumptions in prune-dts to break.

Also updated deprecated methods in prune-dts (Firestore-only script that intercepts api-extractor and does some extra things) and create-overloads (adds typings to compat d.ts files to enable users to use compat and modular instances in the same code) scripts.

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 915f8df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 46 packages
Name Type
@firebase/rules-unit-testing Patch
@firebase/analytics Patch
@firebase/analytics-compat Patch
@firebase/analytics-interop-types Patch
@firebase/analytics-types Patch
@firebase/app Patch
@firebase/app-check Patch
@firebase/app-check-compat Patch
@firebase/app-check-interop-types Patch
@firebase/app-check-types Patch
@firebase/app-compat Patch
@firebase/app-types Patch
@firebase/auth Patch
@firebase/auth-compat Patch
@firebase/auth-interop-types Patch
@firebase/auth-types Patch
@firebase/component Patch
@firebase/database Patch
@firebase/database-compat Patch
@firebase/database-types Patch
firebase Minor
@firebase/firestore Patch
@firebase/firestore-compat Patch
@firebase/firestore-types Patch
@firebase/functions Patch
@firebase/functions-compat Patch
@firebase/functions-types Patch
@firebase/installations Patch
@firebase/installations-compat Patch
@firebase/installations-types Patch
@firebase/logger Patch
@firebase/messaging Patch
@firebase/messaging-compat Patch
@firebase/messaging-interop-types Patch
@firebase/messaging-types Patch
@firebase/performance Patch
@firebase/performance-compat Patch
@firebase/performance-types Patch
@firebase/remote-config Patch
@firebase/remote-config-compat Patch
@firebase/remote-config-types Patch
@firebase/storage Patch
@firebase/storage-compat Patch
@firebase/storage-types Patch
@firebase/util Patch
@firebase/webchannel-wrapper Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 11, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (2012b6b)Merge (e9944c7)Diff
    browser266 kB266 kB+12 B (+0.0%)
    esm5330 kB330 kB+12 B (+0.0%)
    module266 kB266 kB+12 B (+0.0%)
    react-native266 kB266 kB+12 B (+0.0%)

  • @firebase/firestore-lite

    TypeBase (2012b6b)Merge (e9944c7)Diff
    browser82.2 kB82.3 kB+32 B (+0.0%)
    esm598.4 kB98.5 kB+32 B (+0.0%)
    module82.2 kB82.3 kB+32 B (+0.0%)
    react-native82.4 kB82.4 kB+32 B (+0.0%)

  • @firebase/rules-unit-testing

    TypeBase (2012b6b)Merge (e9944c7)Diff
    main17.6 kB17.8 kB+248 B (+1.4%)

  • bundle

    12 size changes

    TypeBase (2012b6b)Merge (e9944c7)Diff
    firestore (Persistence)276 kB276 kB+64 B (+0.0%)
    firestore (Query Cursors)213 kB213 kB+48 B (+0.0%)
    firestore (Query)214 kB214 kB+48 B (+0.0%)
    firestore (Read data once)202 kB202 kB+48 B (+0.0%)
    firestore (Realtime updates)205 kB205 kB+48 B (+0.0%)
    firestore (Transaction)186 kB186 kB+24 B (+0.0%)
    firestore (Write data)186 kB186 kB+48 B (+0.0%)
    firestore-lite (Query Cursors)71.4 kB71.4 kB+24 B (+0.0%)
    firestore-lite (Query)74.6 kB74.6 kB+24 B (+0.0%)
    firestore-lite (Read data once)58.9 kB59.0 kB+24 B (+0.0%)
    firestore-lite (Transaction)83.5 kB83.6 kB+24 B (+0.0%)
    firestore-lite (Write data)68.7 kB68.7 kB+24 B (+0.0%)

  • firebase

    TypeBase (2012b6b)Merge (e9944c7)Diff
    firebase-compat.js740 kB740 kB+4 B (+0.0%)
    firebase-firestore-compat.js313 kB313 kB+4 B (+0.0%)
    firebase-firestore-lite.js88.9 kB89.0 kB+32 B (+0.0%)
    firebase-firestore.js314 kB314 kB+12 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/O8VzbK9w1i.html

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2022 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@hsubox76 hsubox76 marked this pull request as ready for review October 13, 2022 18:19