Firebase Installations: Instance ID now uses FIS under the hood. #3398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit b036c34 Merge: 8efea87 ee174c1 Author: Maksym Malyhin <[email protected]> Date: Fri Jun 7 14:39:29 2019 -0400 Merge branch 'mm/fis-master' into mm/fid-fid commit 8efea87 Author: Maksym Malyhin <[email protected]> Date: Fri Jun 7 14:24:43 2019 -0400 Run ./scripts/style.sh commit f44f475 Author: Maksym Malyhin <[email protected]> Date: Fri Jun 7 14:21:21 2019 -0400 FIRInstallationsTests update to mock installationsIDController commit 0d3b761 Author: Maksym Malyhin <[email protected]> Date: Fri Jun 7 11:59:13 2019 -0400 FID 22 chars long. commit 84feb3e Author: Maksym Malyhin <[email protected]> Date: Fri Jun 7 11:40:08 2019 -0400 FirebaseIDController tests commit 5b4d866 Author: Maksym Malyhin <[email protected]> Date: Fri Jun 7 10:47:21 2019 -0400 FIRInstallationsIDController draft commit 52b5caf Author: Maksym Malyhin <[email protected]> Date: Thu Jun 6 16:19:16 2019 -0400 [WIP] FID commit aad6d17 Author: Maksym Malyhin <[email protected]> Date: Thu Jun 6 15:47:22 2019 -0400 23 chars long FID commit 9bb7ed3 Author: Maksym Malyhin <[email protected]> Date: Thu Jun 6 15:44:35 2019 -0400 Generate 22 chars FID
maksymmalyhin
commented
Jul 19, 2019
scripts/pod_lib_lint.rb
Outdated
| @@ -42,13 +48,28 @@ def main(args) | |||
|
|
|||
| command = %w(bundle exec pod lib lint --sources=https://cdn.cocoapods.org/) | |||
|
|
|||
| # Split arguments that need to be processed by the script itself and passed | |||
| # to the pod command. | |||
| script_args = {} | |||
There was a problem hiding this comment.
@wilhuff I invited you to provide the feedback on the pod_lib_lint.rb and .travis.yaml changes.
|
Run |
|
The Firebase.xcodeproj is broken. I'm hoping to delete this soon, so we could try to accelerate that if it's hard to fix. |
paulb777
approved these changes
Jul 22, 2019
charlotteliang
requested changes
Jul 22, 2019
| @@ -15,15 +15,18 @@ | |||
| */ | |||
|
|
|||
| #import "FIRInstanceID+Private.h" | |||
| #import "FIRInstanceID_Private.h" | |||
|
|
|||
| #import <FirebaseInstallations/FirebaseInstallations.h> | |||
There was a problem hiding this comment.
should this header go on top of all the headers of IID?
charlotteliang
approved these changes
Jul 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./scripts/pod_lib_lint.rb.: a parameter--ignore-local-specsto accommodate FirebaseInstallations tests requiring a particular version of FirebaseInstanceID