Skip to content

Expose authdataresult.credential.secret in public header. #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2019
Merged

Expose authdataresult.credential.secret in public header. #3089

merged 2 commits into from
Jun 24, 2019

Conversation

Yue-Wang-Google
Copy link
Contributor

No description provided.

@Yue-Wang-Google
Copy link
Contributor Author

Relevant design docs: https://docs.google.com/document/d/1iBprlRsVGcIPwodPD976N52gtEUKFFnZLH1YeVgz10o/edit#
https://docs.google.com/document/d/1FZuAXbiMQK23aElPF7POms7Ae2zQpa8nKUx59Z52xFA/edit

@Yue-Wang-Google Yue-Wang-Google mentioned this pull request May 27, 2019
Merged
renkelvin
renkelvin reviewed May 28, 2019
View reviewed changes
@renkelvin
Copy link
Contributor

LGTM. I'll approve and merge this pr when the launch is ready.

@renkelvin renkelvin self-assigned this May 29, 2019
@renkelvin renkelvin merged commit 62150e7 into master Jun 24, 2019
@renkelvin renkelvin deleted the expose branch June 24, 2019 20:46
@firebase firebase locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@renkelvin renkelvin renkelvin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@renkelvin renkelvin

Labels
api: auth cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yue-Wang-Google @renkelvin @morganchen12 @googlebot