Skip to content

FIRMessagingRemoteNotificationsProxy updated to use GULAppDelegateSwizzler #2683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Apr 4, 2019
Merged

FIRMessagingRemoteNotificationsProxy updated to use GULAppDelegateSwizzler #2683

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
b2eabf2
FIRAuthAppDelegateProxy: implementation updated to use GULAppDelegate…
maksymmalyhin Mar 26, 2019
4ab86de
GULAppDelegateSwizzler - make sure subclass name is unique.
maksymmalyhin Mar 27, 2019
1f1560a
GoogleUtilities: enable code coverage
maksymmalyhin Mar 27, 2019
f4a4638
Merge branch 'master'
maksymmalyhin Mar 27, 2019
9fcedce
GULAppDelegateSwizzler: Add support of remote notification methods
maksymmalyhin Mar 27, 2019
27c8b5b
GULAppDelegateSwizzler - tests for remote notification methods
maksymmalyhin Mar 27, 2019
dee28d3
Revert "FIRAuthAppDelegateProxy: implementation updated to use GULApp…
maksymmalyhin Mar 27, 2019
5821591
FIRMessaging: prepare to use GULAppDelegateSwizzler [WIP]
maksymmalyhin Mar 27, 2019
908b6ea
FIRMessagingRemoteNotificationsProxy - use GULAppDelegateSwizzler [WIP]
maksymmalyhin Mar 28, 2019
9e377d2
FIRMessagingRemoteNotificationsProxy - AppDelegate proxy - test only …
maksymmalyhin Mar 28, 2019
7861cde
FIRMessagingRemoteNotificationsProxy test only public API with no imp…
maksymmalyhin Mar 28, 2019
b7703ac
Cleanup
maksymmalyhin Mar 28, 2019
ad1da54
Cleanup
maksymmalyhin Mar 28, 2019
2bdf353
Merge branch 'master'
maksymmalyhin Mar 28, 2019
8eafece
Merge branch 'mm/messaging-tests'
maksymmalyhin Mar 28, 2019
e5d2ce8
Merge branch 'master'
maksymmalyhin Mar 29, 2019
86ff257
Cocoapods 1.6.1: Podfile supports only single post_install hook. It i…
maksymmalyhin Mar 29, 2019
79b7613
FIRMessagingRemoteNotificationsProxyTest: [GULAppDelegateSwizzler res…
maksymmalyhin Mar 29, 2019
98ffccb
FIRMessagingRemoteNotificationsProxy: app delegate missing methods te…
maksymmalyhin Mar 29, 2019
cd44395
GULAppDelegateSwizzler: don't swizzle invalid application delegate
maksymmalyhin Mar 29, 2019
3df4140
Cleanup
maksymmalyhin Mar 29, 2019
dcd0e10
Run ./scripts/check.sh
maksymmalyhin Mar 29, 2019
18381dd
Merge branch 'master'
maksymmalyhin Apr 1, 2019
dae75d9
GoogleUtilities/GULAppDelegateSwizzler - tvOS support
maksymmalyhin Apr 1, 2019
6dee8d3
style.sh generated changes
maksymmalyhin Apr 1, 2019
2726e7c
FirebaseMessaging - missing dependencies added
maksymmalyhin Apr 1, 2019
63fd1f5
FCM data channel messages - pass data to [FIRMessaging appDidReceiveM…
maksymmalyhin Apr 1, 2019
4a3fbb1
FIRMessagingRemoteNotificationsProxyTest - remove GULLoggerForceDebug()
maksymmalyhin Apr 2, 2019
b390f4f
GULAppDelegateSwizzler - add deprecated `application:didReceiveRemote…
maksymmalyhin Apr 2, 2019
236877d
Merge branch 'master'
maksymmalyhin Apr 3, 2019
3641d35
Merge branch 'master'
maksymmalyhin Apr 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Run ./scripts/check.sh
  • Loading branch information
@maksymmalyhin
maksymmalyhin committed Mar 29, 2019
commit dcd0e10a23503fc6ed567a34502587e4b854b73e
12 changes: 7 additions & 5 deletions GoogleUtilities/AppDelegateSwizzler/GULAppDelegateSwizzler.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,11 +835,13 @@ - (void)application:(UIApplication *)application

+ (void)proxyAppDelegate:(id<UIApplicationDelegate>)appDelegate {
if (![appDelegate conformsToProtocol:@protocol(UIApplicationDelegate)]) {
GULLogNotice(kGULLoggerSwizzler, NO,
[NSString stringWithFormat:@"I-SWZ%06ld",
(long)kGULSwizzlerMessageCodeAppDelegateSwizzlingInvalidAppDelegate],
@"App Delegate does not conform to UIApplicationDelegate protocol. %@",
[GULAppDelegateSwizzler correctAlternativeWhenAppDelegateProxyNotCreated]);
GULLogNotice(
kGULLoggerSwizzler, NO,
[NSString
stringWithFormat:@"I-SWZ%06ld",
(long)kGULSwizzlerMessageCodeAppDelegateSwizzlingInvalidAppDelegate],
@"App Delegate does not conform to UIApplicationDelegate protocol. %@",
[GULAppDelegateSwizzler correctAlternativeWhenAppDelegateProxyNotCreated]);
return;
}

Expand Down
28 changes: 14 additions & 14 deletions GoogleUtilities/Common/GULLoggerCodes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,20 @@

typedef NS_ENUM(NSInteger, GULSwizzlerMessageCode) {
// App Delegate Swizzling.
kGULSwizzlerMessageCodeAppDelegateSwizzling000 = 1000, // I-SWZ001000
kGULSwizzlerMessageCodeAppDelegateSwizzling001 = 1001, // I-SWZ001001
kGULSwizzlerMessageCodeAppDelegateSwizzling002 = 1002, // I-SWZ001002
kGULSwizzlerMessageCodeAppDelegateSwizzling003 = 1003, // I-SWZ001003
kGULSwizzlerMessageCodeAppDelegateSwizzling004 = 1004, // I-SWZ001004
kGULSwizzlerMessageCodeAppDelegateSwizzling005 = 1005, // I-SWZ001005
kGULSwizzlerMessageCodeAppDelegateSwizzling006 = 1006, // I-SWZ001006
kGULSwizzlerMessageCodeAppDelegateSwizzling007 = 1007, // I-SWZ001007
kGULSwizzlerMessageCodeAppDelegateSwizzling008 = 1008, // I-SWZ001008
kGULSwizzlerMessageCodeAppDelegateSwizzling009 = 1009, // I-SWZ001009
kGULSwizzlerMessageCodeAppDelegateSwizzling010 = 1010, // I-SWZ001010
kGULSwizzlerMessageCodeAppDelegateSwizzling011 = 1011, // I-SWZ001011
kGULSwizzlerMessageCodeAppDelegateSwizzling012 = 1012, // I-SWZ001012
kGULSwizzlerMessageCodeAppDelegateSwizzling013 = 1013, // I-SWZ001013
kGULSwizzlerMessageCodeAppDelegateSwizzling000 = 1000, // I-SWZ001000
kGULSwizzlerMessageCodeAppDelegateSwizzling001 = 1001, // I-SWZ001001
kGULSwizzlerMessageCodeAppDelegateSwizzling002 = 1002, // I-SWZ001002
kGULSwizzlerMessageCodeAppDelegateSwizzling003 = 1003, // I-SWZ001003
kGULSwizzlerMessageCodeAppDelegateSwizzling004 = 1004, // I-SWZ001004
kGULSwizzlerMessageCodeAppDelegateSwizzling005 = 1005, // I-SWZ001005
kGULSwizzlerMessageCodeAppDelegateSwizzling006 = 1006, // I-SWZ001006
kGULSwizzlerMessageCodeAppDelegateSwizzling007 = 1007, // I-SWZ001007
kGULSwizzlerMessageCodeAppDelegateSwizzling008 = 1008, // I-SWZ001008
kGULSwizzlerMessageCodeAppDelegateSwizzling009 = 1009, // I-SWZ001009
kGULSwizzlerMessageCodeAppDelegateSwizzling010 = 1010, // I-SWZ001010
kGULSwizzlerMessageCodeAppDelegateSwizzling011 = 1011, // I-SWZ001011
kGULSwizzlerMessageCodeAppDelegateSwizzling012 = 1012, // I-SWZ001012
kGULSwizzlerMessageCodeAppDelegateSwizzling013 = 1013, // I-SWZ001013
kGULSwizzlerMessageCodeAppDelegateSwizzlingInvalidAppDelegate = 1014, // I-SWZ001014

// Method Swizzling.
Expand Down