Pass UTM parameters to dynamic_link_fist_open after fresh install #2461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he first time (thus url is read from the clipboard on run rather than received via deep link)
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
damienix
commented
Feb 28, 2019
| @@ -40,10 +46,13 @@ - (NSURL *)URLWithCustomURLScheme:(NSString *)customURLScheme { | |||
| NSURL *URL; | |||
| if (_dynamicLink) { | |||
| NSString *queryString = FIRDLURLQueryStringFromDictionary(_dynamicLink.parametersDictionary); | |||
| NSString *utmFormatString = @"&utm_medium=%@&utm_campaign=%@&utm_source=%@"; | |||
There was a problem hiding this comment.
I know this is crappy, but enough for demo purposes.
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Closing in favor of #2478. Thanks for getting it started! |
|
Sure thing, it served its purpose! :) Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change that intends to demonstrate better (via code) the issue I'm facing with attribution of
dynamic_link_first_openevent - #2462.I don't really intend to merge this at this stage. Please be forgiving, this is my first Objective C code, and I didn't manage to completely understand the code around, mostly I tried to understand where my problem is and patch it.