Allow Bundle IDs that have a valid prefix #2430
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows iOS Extensions that have a Bundle ID of the format `com.google.appName.extension`
ryanwilson
requested changes
Feb 22, 2019
| for (NSBundle *bundle in bundles) { | ||
| if ([bundle.bundleIdentifier isEqualToString:bundleIdentifier]) { | ||
| // This allows app extensions that have the app's bundle as their prefix to pass this test. | ||
| if ([bundleIdentifier hasPrefix:bundle.bundleIdentifier]) { |
There was a problem hiding this comment.
We want to be a bit more careful here I think - this would match on things like com.firebase.foobar or com.firebase.foo.staging where it should only match on com.firebase.foo.
We could change the method call to matchesBundleIdentifier:inBundles: which could do an exact string match if it's not an extension, but if it is, compare to ensure it's the entire bundleID + a period + an extension identifier.
There's an existing isAppExtension call in GoogleUtilities I believe we could use, and if that's true, separate by ., drop the last one, and re-assemble to verify that it's identical.
|
Closed in favor of #2515 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows iOS Extensions that have a Bundle ID of the format
com.google.appName.extension