Skip to content

Conversation

ryanwilson
Copy link
Member

@ryanwilson ryanwilson commented Nov 1, 2018

Explicitly check for nil instead of using the ! operator on the pointer.

Explicitly check for `nil` instead of using the `!` operator on the pointer.
@ryanwilson ryanwilson modified the milestones: M37, M38 Nov 1, 2018
@ryanwilson ryanwilson merged commit 7e5ba60 into master Nov 1, 2018
ryanwilson added a commit that referenced this pull request Nov 1, 2018
ryanwilson added a commit that referenced this pull request Nov 1, 2018
paulb777 added a commit that referenced this pull request Nov 1, 2018
bstpierr added a commit that referenced this pull request Nov 9, 2018
* master: (128 commits)
  Add a nanopb string (#1839)
  Update Auth samples to sync with internal changes (#2056)
  Add clang-format installation instructions (#2057)
  Delete Firestore public C++ API (#2050)
  Porting Multi-Tab Structural Changes (#2049)
  Remove Mutation tombstones (#2052)
  Release 5.12.0 (#2051)
  Fix analyze errors (#2047)
  Isolate Firestore nanopb messages in C++ namespaces (#2046)
  Fix auth multi app support (#2043)
  Add missing nanopb flag (#2042)
  Delete deprecated files (#2038)
  Address travis timeout flakes (#2033)
  Fix tablet layout for in-app messaging (#2032)
  Held Write Acks Changelog (#2037)
  Remove Held Write Acks (#2029)
  Move #2034 into 5.12.0 (#2036)
  Partially revert "Update CHANGELOG for Firestore v0.14.0 (#2025)" (#2031)
  Revert "gRPC: replace Objective-C implementation with the new C++ implementation (#1968)" (#2030)
  Update CHANGELOG.md for #2034 (#2035)
  ...
rsgowman added a commit that referenced this pull request Nov 27, 2018
* Allow for custom domains in the FDL iOS SDK

Allow for custo domains to be whitelisted by the info.plist file.

* Fix style. Run ./scripts/style.sh

* style

* Update versions for Release 5.11.0

* Update Firestore Generated Protos (#1972)

* Remove cruft from project file (#1975)

* Lock reads and writes to session map

* Changed FDL to use compatible __typeof__() operator. (#1982)

typeof() is not supported in some C language dialects which causes
issues when integrating FDL in projects that do use non-GNU compiler modes.

For example, this causes problems when building in some versions of Unity
firebase/quickstart-unity#228

* Changed FDL to use compatible __typeof__() operator. (#1982)

typeof() is not supported in some C language dialects which causes
issues when integrating FDL in projects that do use non-GNU compiler modes.

For example, this causes problems when building in some versions of Unity
firebase/quickstart-unity#228

* Bump DynamicLinks patch version

* Add FDL to release manifest

* Bump GoogleUtilities patch version to deliver fix for #1964 (#1987)

* Wrap diagnostics notification in collection flag check. (#1979)

* Wrap diagnostics notification in collection flag check.

Some of the diagnostics notifications were missed and not covered by
the data collection flag.

* Remove redundant notification call, move Core diagnostics API call.

* Removed configure with no options test.

* Queue Storage Tasks on separate queue (#1981)

* Increase timeout for testDispatchAfterDelay (#1988)

* Update Storage Changelog (#1989)

* Add missing FirebaseStorage release note (#1990)

* Allow semicolon in file name (#1991)

*  Remove unnecessary notification flag (#1993)

* Remove unnecessary notification flag.

This was added when the Google pod could configure Firebase but the
Google pod is deprecated and can only work with Firebase 3.X. These
flags and conditional checks can be safely removed.

* Resolve issues from commit split.

* Style fixes.

* Reduce singleton usage in FIRApp tests. (#1995)

* Reduce singleton usage in FIRApp tests.

There have been some issues while creating new tests of conflicts with
mocks of classes and instances, this should alleviate some of those
conflicts in the future.

* Remove bad style changes.

* Use default app name flag instead of local variable.

* Comply with c99 standard (#1992)

* Trigger travis for Firestore podspec changes

* Use C99-compatible __typeof__ instead of typeof (#1985)

`typeof` is only defined if you compile with GNU extensions, while
`__typeof__` is always available.

This is the Firestore equivalent of #1982.

Note that Firestore won't yet build in this mode because among other
things the Objective-C gRPC still uses `typeof`. Once we eliminate that
dependency this might become possible.

* Adding AppCode Diff (#1996)

* Remove warning (#1999)

* Add InAppMessaging to Carthage template (#2006)

* Restore SafariServices framework (#2002)

* SafariServices not available on tvOS and not used on osx

* Force Firestore to conform to C99 and C++11. (#2001)

Note that c++0x is how Xcode spells c++11.

Also fix an issue where we were accidentally using a C++14 feature.

* Changing the internal testing repo (#2003)

* Clean up test. The issue has already been fixed and we are now running integration test with actual server instead of hexa. (#2007)

* gRPC: replace Objective-C implementation with the new C++ implementation (