Skip to content

[Vertex AI] Add pod to FirebaseManifest #13586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 9, 2024
Merged

[Vertex AI] Add pod to FirebaseManifest #13586

merged 3 commits into from
Sep 9, 2024

Conversation

andrewheard
Copy link
Contributor

Added the FirebaseVertexAI pod to the FirebaseManifest.

Note: Currently needs allowWarnings: true because we emit the following warning on watchOS and tvOS.

firebase-ios-sdk/FirebaseVertexAI/Sources/Constants.swift

Lines 17 to 19 in 413dfef

#if !os(macOS) && !os(iOS)
#warning("Only iOS, macOS, and Catalyst targets are currently fully supported.")
#endif

#no-changelog

paulb777
paulb777 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green zip build and tests and testing the zip binary instructions in a Vertex AI sample app.

Also, ok to punt this to next milestone since it seems a bit tight.

@andrewheard andrewheard mentioned this pull request Sep 9, 2024
Closed
@andrewheard andrewheard marked this pull request as ready for review September 9, 2024 20:26
@andrewheard
Copy link
Contributor Author

LGTM on green zip build and tests and testing the zip binary instructions in a Vertex AI sample app.

I tested the zip (see #13607) and CocoaPods (see #13609) integrations in our sample app and didn't notice any issues.

Note: Although the version is 11.2-beta, zip and pod support won't be available until the Firebase 11.3 release.

@andrewheard andrewheard merged commit 3d035c1 into main Sep 9, 2024
66 checks passed
@andrewheard andrewheard deleted the ah/vertex-zip branch September 9, 2024 20:33
This was referenced Sep 30, 2024
Closed
Merged
Merged
@firebase firebase locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: firebaseai release-tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewheard @paulb777 @google-oss-bot