Skip to content

[Vertex AI] Prepare podspec for a CocoaPods release #13585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 4, 2024
Merged

[Vertex AI] Prepare podspec for a CocoaPods release #13585

merged 5 commits into from
Sep 4, 2024

Conversation

andrewheard
Copy link
Contributor

  • Renamed FirebaseVertexAI-Docs.not_podspec to FirebaseVertexAI.podspec in preparation for a CocoaPods release
  • Removed an extraneous dependency on SharedTestUtilities
  • Updated resource loading to handle both SPM and CocoaPods tests

Note: CI and ZipBuilder changes will still be needed before a release.

#no-changelog

@andrewheard andrewheard requested a review from paulb777 September 4, 2024 20:07
paulb777
paulb777 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok for it to be a follow up PR, but a podspec build and tests should be added to CI similar to other products

Also configuration is needed to include in the zip build

Does anything need to change on the docs gen side to find the new path?

@andrewheard
Copy link
Contributor Author

I'm ok for it to be a follow up PR, but a podspec build and tests should be added to CI similar to other products

Also configuration is needed to include in the zip build

Does anything need to change on the docs gen side to find the new path?

@paulb777 I'm working on adding a pod-lib-lint job similar to the storage one in another PR. Any other tests that should be included as well?

For docs gen, just won't need to manually rename FirebaseVertexAI-Docs.not_podspec to FirebaseVertexAI.podspec first (@morganchen12 please let me know if that's not accurate).

@andrewheard
Copy link
Contributor Author

I'm ok for it to be a follow up PR, but a podspec build and tests should be added to CI similar to other products
Also configuration is needed to include in the zip build
Does anything need to change on the docs gen side to find the new path?

@paulb777 I'm working on adding a pod-lib-lint job similar to the storage one in another PR. Any other tests that should be included as well?

For docs gen, just won't need to manually rename FirebaseVertexAI-Docs.not_podspec to FirebaseVertexAI.podspec first (@morganchen12 please let me know if that's not accurate).

Note: Added a basic pod-lib-lint job in this PR and verified with Morgan for docs generation (he said this would simplify it for him).

@andrewheard andrewheard merged commit 413dfef into main Sep 4, 2024
48 checks passed
@andrewheard andrewheard deleted the ah/vertex-podspec branch September 4, 2024 22:14
@paulb777
Copy link
Member

paulb777 commented Sep 4, 2024

LGTM thanks

@ncooke3 ncooke3 mentioned this pull request Sep 5, 2024
Merged
This was referenced Sep 30, 2024
Closed
Merged
Merged
@firebase firebase locked and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: firebaseai
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewheard @paulb777 @google-oss-bot