Skip to content

[App Check] Implement FirebaseAppCheck as a shim of AppCheckCore #12067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 55 commits into from
Nov 7, 2023
Merged

[App Check] Implement FirebaseAppCheck as a shim of AppCheckCore #12067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
f717e12
Extract GACAppCheckSettings from FIRAppCheckSettings (#11214)
andrewheard May 5, 2023
49e1725
Fork App Check dir for use outside of Firebase (#11247)
andrewheard May 9, 2023
f9d1794
Add AppCheck as a dependency of FirebaseAppCheck (#11257)
andrewheard May 9, 2023
0904e5e
[App Check] Rename FIR symbols in unit tests for generic SDK (#11267)
andrewheard May 10, 2023
e494411
Replace GACAppCheckLogger macros with NSLog wrappers (#11269)
andrewheard May 10, 2023
80f1c4d
Remove Firebase-specific implementation in GACAppCheckStorage (#11273)
andrewheard May 10, 2023
85c4a3d
Extract heartbeat logger from GACAppCheckAPIService (#11277)
andrewheard May 11, 2023
6d95814
[App Check] Expose `initWithApp:appCheckProvider:` (#11288)
andrewheard May 15, 2023
2cf85ca
Remove AppCheckProviderFactory from App Check Lite (#11290)
andrewheard May 15, 2023
de2e1b4
Extract Firebase-specific IDs from GACAppAttestAPIService (#11291)
andrewheard May 16, 2023
f46cf8e
Integrate FirebaseAppCheck changes into AppCheck (#11308)
andrewheard May 22, 2023
b729256
Remove Firebase IDs from GACAppAttestKeyIDStorage (#11309)
andrewheard May 22, 2023
6ce0a6c
Remove Firebase-specific implementation from GACAppCheckAPIService (#…
andrewheard May 24, 2023
ec95877
Extract Firebase symbols from GACAppAttestArtifactStorage (#11334)
andrewheard May 26, 2023
98254b0
Remove FIRApp dependencies from GACAppAttestProvider (#11340)
andrewheard May 26, 2023
aeb8e3f
[App Check] Remove Firebase specifics from Debug Provider (#11349)
andrewheard May 29, 2023
810caea
[App Check] Remove Firebase specifics from DeviceCheck Provider (#11352)
andrewheard May 30, 2023
ebfa41b
Add CI infrastructure for App Check (#11358)
andrewheard May 31, 2023
dde80cd
Remove Firebase specifics from `GACAppCheck` (#11368)
andrewheard May 31, 2023
fa377b0
[App Check] Rename symbols in GACAppCheckLogger (#11381)
andrewheard Jun 2, 2023
e6ebe87
Remove `AppCheckInterop` headers from the `AppCheck` SDK (#11404)
andrewheard Jun 6, 2023
d4abe44
Remove `GACAppCheckSettings` from FirebaseAppCheck (#11375)
andrewheard Jun 6, 2023
7565d0c
Replace `FIRAppCheckDebugProvider` with `GACAppCheckDebugProvider` sh…
andrewheard Jun 7, 2023
2e18f30
Replace `FIRAppAttestProvider` with `GACAppAttestProvider` shim (#11418)
andrewheard Jun 13, 2023
5de35f5
Replace `FIRDeviceCheckProvider` with `GACDeviceCheckProvider` shim (…
andrewheard Jun 15, 2023
f29bd3f
Move `GACAppCheckSettings` implementation back to `FIRAppCheckSetting…
andrewheard Jun 20, 2023
24446ae
[App Check] Remove non-interop API surface (#11512)
andrewheard Jul 6, 2023
482739e
[App Check] Replace token refresh `NSNotification`s with delegate (#1…
andrewheard Jul 11, 2023
20ce34b
[App Check] Copy SharedTestUtilities for Lite SDK (#11530)
andrewheard Jul 11, 2023
a35b0a4
[App Check] Depend on FirebaseCoreExtension via podspec (#11538)
andrewheard Jul 13, 2023
3f54723
[App Check] Support custom base URL (#11542)
andrewheard Jul 13, 2023
4ccfe4f
[App Check] Set `limited_use` request param for App Attest (#11544)
andrewheard Jul 13, 2023
611edba
[App Check] Add `limitedUse` parameter to `GACAppAttestProvider` (#11…
andrewheard Jul 13, 2023
a09b332
[App Check] Add log filtering based on log level (#11570)
andrewheard Jul 19, 2023
d186167
[App Check] Replace `gGACAppCheckLogLevel` with class property (#11572)
andrewheard Jul 20, 2023
40f00d3
Rename Swift symbols to AppCheckCore* (#11576)
andrewheard Jul 20, 2023
ed0e3fe
Cleanup some Firebase references in App Check Core (#11578)
andrewheard Jul 20, 2023
8185a36
Renamed `AppCheck` to `AppCheckCore` (#11581)
andrewheard Jul 21, 2023
0b257f8
Make `tokenDelegate` nullable in `GACAppCheck` (#11592)
andrewheard Jul 24, 2023
59b1a64
Implement `FIRAppCheckSettings` as subclass (#11597)
andrewheard Jul 24, 2023
fb660ae
Remove App Check Core Interop SDK (#11595)
andrewheard Jul 24, 2023
4defb65
[App Check] Rename `instanceName` and `storageID` to `serviceName` (#…
andrewheard Jul 25, 2023
e3f76d7
Depend on `AppCheckCore` staged in `SpecsDev` (#11641)
andrewheard Aug 2, 2023
2b2ee22
Add `baseURL:nil` in debug provider
andrewheard Sep 20, 2023
2169855
Remove `AppCheckCore` directory (#11834)
andrewheard Sep 20, 2023
84dbf97
Implement `FIRAppCheck` as a shim of `GACAppCheck` (#11721)
andrewheard Sep 22, 2023
6b1b752
Fix AppCheckCore import
andrewheard Oct 31, 2023
b481cb5
Replace `@import AppCheckCore` with `#import <...>`
andrewheard Oct 31, 2023
b2758ad
Fix AppCheckE2ETests
andrewheard Oct 31, 2023
a5318a1
Remove FirebaseAppCheckIntegration SPM testTarget
andrewheard Oct 31, 2023
8002773
Update AppCheckCore dependency to 10.18.0 (#12030)
andrewheard Nov 2, 2023
7ace85e
Convert errors from `GACAppCheckErrorDomain` to `FIRAppCheckErrorDoma…
andrewheard Nov 6, 2023
1f1ee2b
[Release] Require `GoogleUtilities/Logger` `7.12` in FirebaseCore (#1…
andrewheard Nov 7, 2023
3db9651
[Core] Add `FIRGetLoggerLevel` function (#12065)
andrewheard Nov 7, 2023
4ff62df
Set `GACAppCheckLogger.logLevel` in Firebase App Check (#12066)
andrewheard Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion FirebaseAppCheck.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ Pod::Spec.new do |s|
s.osx.weak_framework = 'DeviceCheck'
s.tvos.weak_framework = 'DeviceCheck'

s.dependency 'AppCheckCore', '~> 10.18'
s.dependency 'FirebaseAppCheckInterop', '~> 10.17'
s.dependency 'FirebaseCore', '~> 10.0'
s.dependency 'PromisesObjC', '~> 2.1'
Expand Down Expand Up @@ -93,7 +94,6 @@ Pod::Spec.new do |s|
}
swift_unit_tests.source_files = [
base_dir + 'Tests/Unit/Swift/**/*.swift',
base_dir + 'Tests/Unit/Swift/**/*.h',
]
end

Expand Down
65 changes: 0 additions & 65 deletions FirebaseAppCheck/Sources/AppAttestProvider/API/FIRAppAttestAPIService.h
View file
Open in desktop

This file was deleted.

261 changes: 0 additions & 261 deletions FirebaseAppCheck/Sources/AppAttestProvider/API/FIRAppAttestAPIService.m
View file
Open in desktop

This file was deleted.

43 changes: 0 additions & 43 deletions FirebaseAppCheck/Sources/AppAttestProvider/API/FIRAppAttestAttestationResponse.h
View file
Open in desktop

This file was deleted.

Loading