Skip to content

Multiple inequality support #11626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 57 commits into from
Sep 13, 2023
Merged

Multiple inequality support #11626

merged 57 commits into from
Sep 13, 2023

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Jul 27, 2023 •
edited
Loading

@google-oss-bot
Copy link

google-oss-bot commented Jul 27, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.15% (0c9fe27) to 88.17% (8f97b76) by +0.02%.

    14 individual files with coverage change

    FilenameBase (0c9fe27)Merge (8f97b76)Diff
    composite_filter.cc98.25%90.10%-8.15%
    document.nanopb.cc96.67%98.33%+1.67%
    exception.cc23.68%84.21%+60.53%
    field_filter.cc95.24%95.00%-0.24%
    leveldb_index_manager.cc97.72%97.73%+0.01%
    leveldb_key.cc98.82%98.14%-0.69%
    leveldb_mutation_queue.cc92.42%93.56%+1.14%
    leveldb_remote_document_cache.cc94.83%96.55%+1.72%
    ordered_code.cc93.90%94.39%+0.49%
    query.cc98.68%98.43%-0.24%
    query_core.cc96.23%95.80%-0.43%
    serializer.cc90.80%91.00%+0.20%
    target_index_matcher.cc95.28%90.77%-4.51%
    write_stream.cc91.55%94.37%+2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hl3PhAPqG0.html

@milaGGL milaGGL marked this pull request as ready for review August 2, 2023 18:50
@milaGGL milaGGL requested a review from ehsannas August 2, 2023 18:50
milaGGL
milaGGL commented Aug 2, 2023
View reviewed changes
milaGGL
milaGGL commented Aug 2, 2023
View reviewed changes
milaGGL
milaGGL commented Aug 2, 2023
View reviewed changes
ehsannas
ehsannas reviewed Aug 10, 2023
View reviewed changes
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! A few nits pointed out below.

@google-oss-bot
Copy link

google-oss-bot commented Aug 11, 2023 •
edited
Loading

Size Report 1

Affected Products

  • FirebaseFirestore

    TypeBase (afbfb27)Merge (cf0a171)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8MkAj8yBXM.html

@milaGGL milaGGL requested a review from ehsannas August 11, 2023 17:57
ehsannas
ehsannas approved these changes Aug 11, 2023
View reviewed changes
@cherylEnkidu cherylEnkidu removed their assignment Sep 11, 2023
@milaGGL milaGGL merged commit f3c7db7 into master Sep 13, 2023
@milaGGL milaGGL deleted the mila/multiple-inequality-support branch September 13, 2023 21:10
andrewheard pushed a commit that referenced this pull request Sep 20, 2023
@milaGGL @andrewheard
Multiple inequality support (#11626)
29efb85
@milaGGL milaGGL mentioned this pull request Oct 13, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Oct 14, 2023
@milaGGL milaGGL restored the mila/multiple-inequality-support branch April 19, 2024 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas approved these changes

@dconeybe dconeybe dconeybe approved these changes

Assignees

@milaGGL milaGGL

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@milaGGL @google-oss-bot @dconeybe @ehsannas @cherylEnkidu