[App Check] Remove non-interop API surface #11512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
approved these changes
Jul 6, 2023
andrewheard
added a commit
that referenced
this pull request
Jul 20, 2023
- Removed the `tokenForcingRefresh:completion:` and `limitedUseTokenWithCompletion:` methods from `GACAppCheck` (`getTokenForcingRefresh:completion:` and `getLimitedUseTokenWithCompletion:` from `GACAppCheckInterop` remain). - The `GACAppCheckInterop` method completion handlers now return a `GACAppCheckTokenInterop` or `NSError` instead of a `GACAppCheckTokenResultInterop` (which held either a valid token on success or a dummy token + error on failure). - Removed `GACAppCheckFake` and `GACAppCheckTokenResultFake` from the SDK since these classes were unused. These changes have been done to minimize the `GACAppCheck` API surface while still allowing the `FIRAppCheck` shim to be built.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tokenForcingRefresh:completion:andlimitedUseTokenWithCompletion:methods fromGACAppCheck(getTokenForcingRefresh:completion:andgetLimitedUseTokenWithCompletion:fromGACAppCheckInteropremain).GACAppCheckInteropmethod completion handlers now return aGACAppCheckTokenInteroporNSErrorinstead of aGACAppCheckTokenResultInterop(which held either a valid token on success or a dummy token + error on failure).GACAppCheckFakeandGACAppCheckTokenResultFakefrom the SDK since these classes were unused.These changes have been done to minimize the
GACAppCheckAPI surface while still allowing theFIRAppCheckshim to be built.#no-changelog