Skip to content

Add option to allow SDK create cache indexes automatically to improve query execution locally #11596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 29, 2023
Merged

Add option to allow SDK create cache indexes automatically to improve query execution locally #11596

merged 14 commits into from
Aug 29, 2023

Conversation

cherylEnkidu
Copy link
Contributor

@cherylEnkidu cherylEnkidu commented Jul 24, 2023 •
edited
Loading

Preparing work for index auto creation feature.
#no-changelog

@cherylEnkidu cherylEnkidu force-pushed the cheryllin/autoIndexing branch from 338b6fd to e065099 Compare July 24, 2023 18:50
@firebase firebase deleted a comment from google-oss-bot Jul 24, 2023
@google-oss-bot
Copy link

google-oss-bot commented Jul 24, 2023 •
edited
Loading

Size Report 1

Affected Products

  • FirebaseFirestore

    TypeBase (3df15ba)Merge (a3ff892)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NT3XGjxxDM.html

@cherylEnkidu cherylEnkidu force-pushed the cheryllin/autoIndexing branch 4 times, most recently from 9c0f65d to 3f248b8 Compare July 26, 2023 19:41
@cherylEnkidu cherylEnkidu force-pushed the cheryllin/autoIndexing branch from 3f248b8 to c58480a Compare July 26, 2023 20:23
@google-oss-bot
Copy link

google-oss-bot commented Jul 26, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.12% (2e7eecd) to 88.14% (5180393) by +0.02%.

    17 individual files with coverage change

    FilenameBase (2e7eecd)Merge (5180393)Diff
    exception.cc84.21%23.68%-60.53%
    firestore.cc92.13%92.41%+0.28%
    firestore_client.cc98.91%98.94%+0.03%
    FIRFirestore.mm88.70%88.97%+0.27%
    FIRPersistentCacheIndexManager.mm?100.00%?
    leveldb_index_manager.cc97.67%97.72%+0.06%
    leveldb_key.cc98.14%98.82%+0.69%
    leveldb_opener.cc76.81%78.99%+2.17%
    leveldb_persistence.cc90.82%92.31%+1.49%
    leveldb_remote_document_cache.cc96.41%96.55%+0.14%
    local_documents_view.cc96.86%96.92%+0.06%
    memory_index_manager.cc50.00%51.61%+1.61%
    memory_persistence.cc100.00%97.37%-2.63%
    memory_remote_document_cache.cc93.51%93.83%+0.32%
    persistent_cache_index_manager.cc?100.00%?
    query_engine.cc98.28%98.68%+0.40%
    target_index_matcher.cc97.80%95.28%-2.53%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/DMi2ycmIRI.html

@cherylEnkidu cherylEnkidu force-pushed the cheryllin/autoIndexing branch 2 times, most recently from e1250c4 to 7c8e0ac Compare July 30, 2023 02:08
@cherylEnkidu cherylEnkidu force-pushed the cheryllin/autoIndexing branch from 7c8e0ac to 900f034 Compare July 30, 2023 02:48
@cherylEnkidu cherylEnkidu force-pushed the cheryllin/autoIndexing branch from 6deacda to 36202ff Compare August 13, 2023 01:48
@cherylEnkidu cherylEnkidu force-pushed the cheryllin/autoIndexing branch from f65ba9c to 758c809 Compare August 15, 2023 20:16
cherylEnkidu
cherylEnkidu commented Aug 15, 2023
View reviewed changes
@cherylEnkidu cherylEnkidu force-pushed the cheryllin/autoIndexing branch from 32c4d88 to 6a8582b Compare August 15, 2023 23:15