Skip to content

Remove isFetchInProgress check for real-time initiated Fetches #11465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 28, 2023
Merged

Remove isFetchInProgress check for real-time initiated Fetches #11465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d6e6eed
cast listener with __block so that it can be altered within block
qdpham13 Jun 20, 2023
a5ab9c7
Increase fetch attempt
qdpham13 Jun 21, 2023
a85867c
Merge branch 'master'
qdpham13 Jun 21, 2023
4560440
Remove isFetchInProgress check for real-time initiated fetches
qdpham13 Jun 22, 2023
e008c10
Update changeling
qdpham13 Jun 27, 2023
7b125f6
update changelog to be more specific
qdpham13 Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions FirebaseRemoteConfig/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# 10.12.0
- [fixed] Fix issue of real-time listeners not being properly removed. (#11458)
- [fixed] Fix real-time fetches not being able to fetch the latest template due to an in-progress fetch. (#11465)
# 10.7.0
- [feature] Added support for real-time config updates. Use the new `addOnConfigUpdateListener` API to get
real-time updates. Existing [`fetch`](https://firebase.google.com/docs/reference/swift/firebaseremoteconfig/api/reference/Classes/RemoteConfig#fetch)
Expand Down
25 changes: 0 additions & 25 deletions FirebaseRemoteConfig/Sources/RCNConfigFetch.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,31 +208,6 @@ - (void)realtimeFetchConfigWithNoExpirationDuration:(NSInteger)fetchAttemptNumbe
if (strongSelf == nil) {
return;
}

// Check if a fetch is already in progress.
// TODO: for this case should we still return a SUCCESS status?
if (strongSelf->_settings.isFetchInProgress) {
// Check if we have some fetched data.
if (strongSelf->_settings.lastFetchTimeInterval > 0) {
FIRLogDebug(kFIRLoggerRemoteConfig, @"I-RCN000052",
@"A fetch is already in progress. Using previous fetch results.");
FIRRemoteConfigUpdate *update =
[self->_content getConfigUpdateForNamespace:self->_FIRNamespace];
return [strongSelf reportCompletionWithStatus:strongSelf->_settings.lastFetchStatus
withUpdate:update
withError:nil
completionHandler:nil
updateCompletionHandler:completionHandler];
} else {
FIRLogError(kFIRLoggerRemoteConfig, @"I-RCN000053",
@"A fetch is already in progress. Ignoring duplicate request.");
return [strongSelf reportCompletionWithStatus:FIRRemoteConfigFetchStatusFailure
withUpdate:nil
withError:nil
completionHandler:nil
updateCompletionHandler:completionHandler];
}
}
// Check whether cache data is within throttle limit.
if ([strongSelf->_settings shouldThrottle] && !hasDeviceContextChanged) {
// Must set lastFetchStatus before FailReason.
Expand Down