[Unit tests] TOTP Enrollment #11399
Merged
[Unit tests] TOTP Enrollment #11399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Apple API Diff ReportCommit: a8ba522 FirebaseAuthClasses[ADDED] FIRTOTPSecret[ADDED] FIRTOTPSecretSwift:
+ class TOTPSecret : NSObject
+ func sharedSecretKey () -> String
+ func generateQRCodeURL ( withAccountName accountName : String , issuer : String ) -> String
+ func openInOTPApp ( withQRCodeURL QRCodeURL : String )
Objective-C:
+ @interface FIRTOTPSecret : NSObject
+ - ( nonnull NSString * ) sharedSecretKey ;
+ - ( nonnull NSString * ) generateQRCodeURLWithAccountName :( nonnull NSString * ) accountName issuer :( nonnull NSString * ) issuer ;
+ - ( void ) openInOTPAppWithQRCodeURL :( nonnull NSString * ) QRCodeURL ;[ADDED] FIRTOTPMultiFactorGenerator[ADDED] FIRTOTPMultiFactorGeneratorObjective-C:
+ @interface FIRTOTPMultiFactorGenerator : NSObject
+ + ( void ) generateSecretWithMultiFactorSession : ( nonnull FIRMultiFactorSession * ) session completion :( nonnull void ( ^ )( FIRTOTPSecret * _Nullable , NSError * _Nullable )) completion ;
+ + ( nonnull FIRTOTPMultiFactorAssertion * ) assertionForEnrollmentWithSecret :( nonnull FIRTOTPSecret * ) secret oneTimePassword :( nonnull NSString * ) oneTimePassword ;
+ + ( nonnull FIRTOTPMultiFactorAssertion * ) assertionForSignInWithEnrollmentID :( nonnull NSString * ) enrollmentID oneTimePassword :( nonnull NSString * ) oneTimePassword ;[ADDED] FIRTOTPMultiFactorAssertion[ADDED] FIRTOTPMultiFactorAssertionObjective-C:
+ @interface FIRTOTPMultiFactorAssertion : FIRMultiFactorAssertionConstants[ADDED] FIRTOTPMultiFactorID[ADDED] FIRTOTPMultiFactorIDObjective-C:
+ extern NSString * const _Nonnull FIRTOTPMultiFactorID |
cd15ad4 to
bc65d32
Compare
bc65d32 to
0a2da8a
Compare
Xiaoshouzi-gh
approved these changes
Jun 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests for start and finalize MFA enrollment flows