provide missing TOTP factor type of error in the error code #11392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
renkelvin
reviewed
Jun 5, 2023
| @@ -425,39 +425,58 @@ - (void)linkWithAuthProvider:(id<AuthProvider>)authProvider retrieveData:(BOOL)r | |||
| [displayNameString appendString:tmpFactorInfo.displayName]; | |||
| [displayNameString appendString:@" "]; | |||
| } | |||
| [self showTextInputPromptWithMessage:[NSString stringWithFormat:@"Select factor to link\n%@", displayNameString] | |||
| [self showTextInputPromptWithMessage:[NSString stringWithFormat:@"Select factor to sign in\n%@", displayNameString] | |||
| @@ -229,7 +229,68 @@ - (void)reauthenticateEmailPassword { | |||
| completion:^(FIRAuthDataResult *_Nullable result, | |||
| NSError *_Nullable error) { | |||
| if (error) { | |||
| [self logFailure:@"reauthicate with email password failed." error:error]; | |||
There was a problem hiding this comment.
Seems the code is duplicated several times. Not a blocker though.
renkelvin
approved these changes
Jun 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If TOTP MFA enrolled, add specific totpMfaInfo in the error list when sign-in with the following first factors -
Updated the sample app to reflect the changes.