Skip to content

Conversation

pragatimodi
Copy link
Contributor

No description provided.

@pragatimodi pragatimodi changed the base branch from master to totp-release-0413 June 2, 2023 23:44
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Apple API Diff Report

Commit: 0ac2bb7
Last updated: Fri Jun 2 16:47 PDT 2023
View workflow logs & download artifacts


FirebaseAuth

Constants

[ADDED] FIRTOTPMultiFactorID
[ADDED] FIRTOTPMultiFactorID
Objective-C:
+  extern NSString * const _Nonnull FIRTOTPMultiFactorID

Classes

[ADDED] FIRTOTPMultiFactorGenerator
[ADDED] FIRTOTPMultiFactorGenerator
Objective-C:
+  @interface FIRTOTPMultiFactorGenerator : NSObject
+    + ( void ) generateSecretWithMultiFactorSession : ( nonnull FIRMultiFactorSession * ) session completion :( nonnull void ( ^ )( FIRTOTPSecret * _Nullable , NSError * _Nullable )) completion ;
+    + ( nonnull FIRTOTPMultiFactorAssertion * ) assertionForEnrollmentWithSecret :( nonnull FIRTOTPSecret * ) secret oneTimePassword :( nonnull NSString * ) oneTimePassword ;
+    + ( nonnull FIRTOTPMultiFactorAssertion * ) assertionForSignInWithEnrollmentID :( nonnull NSString * ) enrollmentID oneTimePassword :( nonnull NSString * ) oneTimePassword ;
[ADDED] FIRTOTPSecret
[ADDED] FIRTOTPSecret
Swift:
+  class TOTPSecret : NSObject
+    func sharedSecretKey () -> String
+    func generateQRCodeURL ( withAccountName accountName : String , issuer : String ) -> String
+    func openInOTPApp ( withQRCodeURL QRCodeURL : String )
Objective-C:
+  @interface FIRTOTPSecret : NSObject
+    - ( nonnull NSString * ) sharedSecretKey ;
+    - ( nonnull NSString * ) generateQRCodeURLWithAccountName :( nonnull NSString * ) accountName issuer :( nonnull NSString * ) issuer ;
+    - ( void ) openInOTPAppWithQRCodeURL :( nonnull NSString * ) QRCodeURL ;
[ADDED] FIRTOTPMultiFactorAssertion
[ADDED] FIRTOTPMultiFactorAssertion
Objective-C:
+  @interface FIRTOTPMultiFactorAssertion : FIRMultiFactorAssertion

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseAuth-iOS-FirebaseAuth.framework

    Overall coverage changed from 69.44% (9099f7f) to 68.35% (0ac2bb7) by -1.09%.

    16 individual files with coverage change

    FilenameBase (9099f7f)Merge (0ac2bb7)Diff
    FIRAuthBackend+MultiFactor.m0.00%12.63%+12.63%
    FIRAuthBackend.m83.94%83.50%-0.44%
    FIRAuthKeychainServices.m59.66%58.80%-0.86%
    FIRAuthProtoFinalizeMFATOTPEnrollmentRequestInfo.m?0.00%?
    FIRAuthProtoFinalizeMFATOTPEnrollmentResponseInfo.m?0.00%?
    FIRAuthProtoFinalizeMFATOTPSignInRequestInfo.m?100.00%?
    FIRAuthProtoMFAEnrollment.m100.00%89.47%-10.53%
    FIRAuthProtoStartMFATOTPEnrollmentRequestInfo.m?0.00%?
    FIRAuthProtoStartMFATOTPEnrollmentResponseInfo.m?0.00%?
    FIRFinalizeMFASignInRequest.m0.00%87.50%+87.50%
    FIRMultiFactor.m12.45%11.83%-0.62%
    FIRMultiFactorResolver.m12.50%11.34%-1.16%
    FIRTOTPMultiFactorAssertion.m?0.00%?
    FIRTOTPMultiFactorGenerator.m?0.00%?
    FIRTOTPMultiFactorInfo.m?0.00%?
    FIRTOTPSecret.m?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xkt7k8FJfR.html

@pragatimodi pragatimodi merged commit db89233 into totp-release-0413 Jun 3, 2023
@pragatimodi pragatimodi deleted the withdraw-mfa branch June 3, 2023 00:15
@firebase firebase locked and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants