Added TOTP MFA Assertion logics #11380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
…ltiFactorGenerator.h
pragatimodi
approved these changes
Jun 1, 2023
| @@ -53,6 +53,15 @@ NS_SWIFT_NAME(TOTPMultiFactorGenerator) API_UNAVAILABLE(macos, tvos, watchos) | |||
| + (FIRTOTPMultiFactorAssertion *)assertionForEnrollmentWithSecret:(FIRTOTPSecret *)secret | |||
| oneTimePassword:(NSString *)oneTimePassword; | |||
|
|
|||
| /** @fn assertionForSignInWithenrollmentID: | |||
There was a problem hiding this comment.
nit: can we move @fn to a new line?
renkelvin
approved these changes
Jun 1, 2023
| finalizedMFARequestInfo = [[FIRAuthProtoFinalizeMFAPhoneRequestInfo alloc] | ||
| initWithSessionInfo:phoneAssertion.authCredential.verificationID | ||
| verificationCode:phoneAssertion.authCredential.verificationCode]; | ||
| } else { |
There was a problem hiding this comment.
I would be safer withelse if (is totp assertion){} and then check if finalizedMFARequestInfo is nil before assigning at L76.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Assertion, generator and resolver logic for TOTP MFA.
Updated the backend rpc call finalizeMFASignInRequest to take TOTP parameters.
This PR is an updated version of #11217.