Skip to content

Remove GACAppCheckSettings from FirebaseAppCheck #11375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 6, 2023
Merged

Remove GACAppCheckSettings from FirebaseAppCheck #11375

merged 5 commits into from
Jun 6, 2023

Conversation

andrewheard
Copy link
Contributor

The GACAppCheckSettings settings class has been migrated into the App Check SDK and is no longer needed in the Firebase App Check SDK.

#no-changelog

@andrewheard
Remove GACAppCheckSettings from FirebaseAppCheck
0ecc1e2 
The `GACAppCheckSettings` settings class has been migrated into the App
Check SDK and is no longer needed in the Firebase App Check SDK.
@andrewheard andrewheard mentioned this pull request Jun 1, 2023
Merged
@andrewheard
Merge ah/appcheck-interop into ah/appcheck-settings
3c68661 
commit be8e01f
Author: Andrew Heard <[email protected]>
Date:   Tue Jun 6 13:05:11 2023 -0400

    Fix integration tests `source_files`

commit af314f8
Author: Andrew Heard <[email protected]>
Date:   Tue Jun 6 11:05:25 2023 -0400

    Remove AppCheckInterop headers from AppCheck SDK

    Removed the headers in `AppCheck/Interop` from the App Check SDK
    `source_files`.

commit 256f5f0
Author: Andrew Heard <[email protected]>
Date:   Fri Jun 2 11:27:12 2023 -0400

    [App Check] Rename symbols in GACAppCheckLogger (#11381)

    The constants in `GACAppCheckLogger` conflict with those in `FIRAppCheckLogger`.
@google-oss-bot
Copy link

1 Warning
⚠️ New public headers were added, did you remember to add them to the umbrella header?

Generated by 🚫 Danger

paulb777
paulb777 approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpecTesting CI failure may be ok for now

@andrewheard andrewheard marked this pull request as ready for review June 6, 2023 20:35
@andrewheard
Copy link
Contributor Author

SpecTesting CI failure may be ok for now

@paulb777 I added a tag named appcheck-lite-10.11.0 for the latest commit in this branch and pushed the AppCheckInterop, AppCheck and FirebaseAppCheck pods to SpecsDev. I used a simple sample app with the following Podfile:

source 'https://github.com/firebase/SpecsDev.git'
source 'https://cdn.cocoapods.org/'

platform :ios, '14.0'

target 'AppCheckTestApp' do
  use_frameworks!

  # Pods for AppCheckTestApp
  pod 'FirebaseAppCheck'
end

This worked fine and cleared up the issue:

Class GACAppCheckSettings is implemented in both .../AppCheckTestApp.app/Frameworks/FirebaseAppCheck.framework/FirebaseAppCheck and .../AppCheckTestApp.app/Frameworks/AppCheck.framework/AppCheck. One of the two will be used. Which one is undefined.

I think it's probably reasonable to ignore the failure for now.

@andrewheard andrewheard merged commit 1f231d2 into appcheck-lite Jun 6, 2023
@andrewheard andrewheard deleted the ah/appcheck-settings branch June 6, 2023 20:36
andrewheard added a commit that referenced this pull request Jun 13, 2023
@andrewheard
Remove GACAppCheckSettings from FirebaseAppCheck (#11375)
2f65e3a 
The `GACAppCheckSettings` settings class has been migrated into the App Check SDK and is no longer needed in the Firebase App Check SDK.
@firebase firebase locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: appcheck
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewheard @google-oss-bot @paulb777