[App Check] Expose initWithApp:appCheckProvider:
#11288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Publicly exposed the `initWithApp:appCheckProvider:` constructor in GACAppCheck for the non-Firebase-specific App Check SDK. Added a podspec for AppCheckInterop and added it as a dependency in the existing AppCheck podspec.
paulb777
approved these changes
May 15, 2023
| #import "AppCheck/Sources/Public/AppCheck/GACDeviceCheckProvider.h" | ||
|
|
||
| @implementation GACDeviceCheckProviderFactory | ||
|
|
||
| + (void)load { |
ncooke3
approved these changes
May 15, 2023
Changed the 'AppCheckInterop' dependency from '~> 10.0' to '~> 10.10' in the AppCheck podspec.
andrewheard
added a commit
that referenced
this pull request
May 19, 2023
Publicly exposed the initWithApp:appCheckProvider: constructor in GACAppCheck for the non-Firebase-specific App Check SDK. Since an AppCheckProvider is explicitly specified when constructing this generic App Check SDK, the AppCheckProviderFactory protocol / pattern / functionality is no longer used. Added a podspec for AppCheckInterop and added it as a dependency in the existing AppCheck podspec. This is a lightweight, protocol-only, dependency that non-Firebase SDKs can make use of.
andrewheard
added a commit
that referenced
this pull request
May 26, 2023
Publicly exposed the initWithApp:appCheckProvider: constructor in GACAppCheck for the non-Firebase-specific App Check SDK. Since an AppCheckProvider is explicitly specified when constructing this generic App Check SDK, the AppCheckProviderFactory protocol / pattern / functionality is no longer used. Added a podspec for AppCheckInterop and added it as a dependency in the existing AppCheck podspec. This is a lightweight, protocol-only, dependency that non-Firebase SDKs can make use of.
andrewheard
added a commit
that referenced
this pull request
May 31, 2023
Publicly exposed the initWithApp:appCheckProvider: constructor in GACAppCheck for the non-Firebase-specific App Check SDK. Since an AppCheckProvider is explicitly specified when constructing this generic App Check SDK, the AppCheckProviderFactory protocol / pattern / functionality is no longer used. Added a podspec for AppCheckInterop and added it as a dependency in the existing AppCheck podspec. This is a lightweight, protocol-only, dependency that non-Firebase SDKs can make use of.
andrewheard
added a commit
that referenced
this pull request
Jun 13, 2023
Publicly exposed the initWithApp:appCheckProvider: constructor in GACAppCheck for the non-Firebase-specific App Check SDK. Since an AppCheckProvider is explicitly specified when constructing this generic App Check SDK, the AppCheckProviderFactory protocol / pattern / functionality is no longer used. Added a podspec for AppCheckInterop and added it as a dependency in the existing AppCheck podspec. This is a lightweight, protocol-only, dependency that non-Firebase SDKs can make use of.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publicly exposed the
initWithApp:appCheckProvider:constructor inGACAppCheckfor the non-Firebase-specific App Check SDK. Since anAppCheckProvideris explicitly specified when constructing this generic App Check SDK, theAppCheckProviderFactoryprotocol / pattern / functionality is no longer used. Remaining references to factories (andFIRApp) will be pruned in follow-up PRs.Added a podspec for
AppCheckInteropand added it as a dependency in the existing AppCheck podspec. This is a lightweight, protocol-only, dependency that non-Firebase SDKs can make use of.#no-changelog