Forked FirebaseAppCheck directory for non-Firebase usage #11247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a "fork" of the FirebaseAppCheck directory and podspec as a
starting point for a generic (non-Firebase-specific) version of the SDK.
- Renamed FirebaseAppCheck files and directories to AppCheck.
- Changed ObjC prefix from FIR to GAC for App Check files and symbols.
- Prefixed Swift names with "Internal".
- Copied and renamed AppCheckBackoffWrapperFake and AppCheckFake from
SharedTestUtilities to AppCheck/Test/Utils.
Note: This is purely a copy and rename of FirebaseAppCheck and it still
depends on FirebaseCore.
Generated by 🚫 Danger |
paulb777
approved these changes
May 8, 2023
andrewheard
added a commit
that referenced
this pull request
May 9, 2023
- Renamed additional FIR-prefixed symbols that were missed in PR #11247. - Removed GACAppCheckComponent since the generic App Check SDK is not intended to register with the Firebase components system directly. - Added `AppCheck` as a dependency of `FirebaseAppCheck`.
andrewheard
added a commit
that referenced
this pull request
May 19, 2023
andrewheard
added a commit
that referenced
this pull request
May 26, 2023
andrewheard
added a commit
that referenced
this pull request
May 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a "fork" of the
FirebaseAppCheckdirectory and podspec as a starting point for a generic (non-Firebase-specific) version of the SDK.FirebaseAppCheckfiles and directories toAppCheck.FIRtoGACfor App Check files and symbols.Internal.AppCheckBackoffWrapperFakeandAppCheckFakefromSharedTestUtilitiestoAppCheck/Tests/Utils.Note: This is purely a copy and rename of
FirebaseAppCheckand it still depends onFirebaseCore.