Skip to content

[ SignIn#2]Update Finalize MFA Sign In request to accommodates TOTP request #11128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 9, 2023
Merged

[ SignIn#2]Update Finalize MFA Sign In request to accommodates TOTP request #11128

merged 6 commits into from
May 9, 2023

Conversation

Xiaoshouzi-gh
Copy link
Contributor

Support TOTP info in FinalizeMFASignInRequest with test.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@pragatimodi pragatimodi changed the base branch from totp-release-0413 to totp-release April 14, 2023 07:35
@pragatimodi pragatimodi changed the base branch from totp-release to totp-release-0413 April 14, 2023 07:35
@Xiaoshouzi-gh Xiaoshouzi-gh marked this pull request as draft April 14, 2023 16:19
@Xiaoshouzi-gh Xiaoshouzi-gh changed the title Update Finalize MFA Sign In request to accommodates TOTP request [ SignIn#2]Update Finalize MFA Sign In request to accommodates TOTP request May 3, 2023
@Xiaoshouzi-gh Xiaoshouzi-gh marked this pull request as ready for review May 3, 2023 20:01
pragatimodi
pragatimodi reviewed May 8, 2023
View reviewed changes
@pragatimodi pragatimodi self-requested a review May 9, 2023 19:49
@Xiaoshouzi-gh Xiaoshouzi-gh merged commit 2ceb2e3 into totp-release-0413 May 9, 2023
@Xiaoshouzi-gh Xiaoshouzi-gh deleted the totp-finalizesignin branch May 9, 2023 21:58
@Xiaoshouzi-gh Xiaoshouzi-gh mentioned this pull request May 9, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@renkelvin renkelvin renkelvin approved these changes

@pragatimodi pragatimodi pragatimodi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xiaoshouzi-gh @google-oss-bot @renkelvin @pragatimodi