App Distro: fix async/await issue #9634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we're calling a completion handler with `nil, nil` when releases are fetched but none are marked as "latest". This shouldn't happen, and is considered an error.
ryanwilson
commented
Apr 11, 2022
|
Chatting with the App Distro team about the expected behaviour here - originally they said it should return an error but now seeing the test failing, it's worth confirming. |
|
Should fix #9604 |
paulb777
reviewed
Apr 11, 2022
FirebaseAppDistribution/Sources/Public/FirebaseAppDistribution/FIRAppDistribution.h
Outdated
Show resolved
Hide resolved
Size Report 1Affected ProductsTest Logs |
paulb777
approved these changes
Apr 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we're calling a completion handler with
nil, nilwhenreleases are fetched but none are marked as "latest". This is an expected result - no new releases but no errors. When translated to async/await, the result is not an optional, which will crash. This turns the return type into an Optional.