Skip to content

Update changelog #8440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2021
Merged

Update changelog #8440

merged 2 commits into from
Jul 27, 2021

Conversation

charlotteliang
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes label Jul 27, 2021
@google-oss-bot
Copy link

google-oss-bot commented Jul 27, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    SDK overall coverage changed from 64.70% (ce87d25) to 64.60% (df7dcbc) by -0.10%.

    Filename Base (ce87d25) Head (df7dcbc) Diff
    FIRMessagingTokenManager.m 42.92% 42.15% -0.77%

Test Logs

@maksymmalyhin
Copy link
Contributor

Please fix CI before merging.

paulb777
paulb777 approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI failures (or flakes) look unrelated and could be dealt with in a separate PR.

@charlotteliang
Copy link
Contributor Author

I think the package.swift change is still needed so I will keep it in this PR?

@charlotteliang charlotteliang merged commit ecc7d6d into master Jul 27, 2021
@charlotteliang charlotteliang deleted the chen-release-note branch July 27, 2021 22:04
maksymmalyhin added a commit that referenced this pull request Jul 29, 2021
@maksymmalyhin
Revert "Update changelog (#8440)"
2aaa73a 
This reverts commit ecc7d6d.
@maksymmalyhin maksymmalyhin mentioned this pull request Jul 29, 2021
Merged
maksymmalyhin added a commit that referenced this pull request Jul 29, 2021
@maksymmalyhin
Revert "Adding a new API that allows iOS users to log notification de…
b8e974d 
…livery signal that exports to BigQuery." (#8458)

* Revert "Prevent firelog from logging invalid data (#8443)"

This reverts commit 7fc7325.

* Revert "Update changelog (#8440)"

This reverts commit ecc7d6d.

* Revert " Adding a new API that allows iOS users to log notification delivery signal that exports to BigQuery. (#6181)"

This reverts commit ce87d25.
@firebase firebase locked and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

+1 more reviewer

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: messaging cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@charlotteliang @google-oss-bot @maksymmalyhin @paulb777