Fix setting of in-app message type in `FIRInAppMessagingImageOnlyDisplay` initializer #8118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

christibbs merged 2 commits into master from fiam-msg-type-bug

May 19, 2021

Contributor

christibbs commented May 19, 2021

Fixes #8081 .

Adds unit test coverage for all message initializers.


          Fix message type in ImageOnlyMessage initializer

089a477

christibbs requested a review from rohandandavati

May 19, 2021 17:43

google-cla bot added the cla: yes label

google-oss-bot added the api: inappmessaging label


          Update CHANGELOG

bf0748c

google-oss-bot commented May 19, 2021 •

edited

Loading

Coverage Report

Affected SDKs

FirebaseInAppMessaging-iOS-FirebaseInAppMessaging.framework

SDK overall coverage changed from 43.92% (5a8c78e) to 45.29% (bf0748c) by +1.37%.

Filename Base (5a8c78e) Head (bf0748c) Diff

FIRIAMDisplayExecutor.m 62.55% 68.73% +6.18%

FIRInAppMessagingRenderingDataClasses.m 42.79% 62.69% +19.90%

Test Logs

Base (5a8c78ef): https://github.com/firebase/firebase-ios-sdk/actions/runs/857376717
Head (bf0748ca): https://github.com/firebase/firebase-ios-sdk/actions/runs/857770755

christibbs enabled auto-merge (squash)

May 19, 2021 18:25

rohandandavati approved these changes

View reviewed changes

christibbs merged commit 62c71f9 into master

christibbs deleted the fiam-msg-type-bug branch

May 19, 2021 18:53

firebase locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: inappmessaging cla: yes