Skip to content

App Check: store App Attest artifact per key ID #8097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 18, 2021
Merged

App Check: store App Attest artifact per key ID #8097

merged 5 commits into from
May 18, 2021

Conversation

maksymmalyhin
Copy link
Contributor

@maksymmalyhin maksymmalyhin commented May 17, 2021 •
edited
Loading

  • make sure an artifact generated for an old App Attest key is not used to generate assertions

#no-changelog

@maksymmalyhin maksymmalyhin requested a review from ncooke3 May 17, 2021 22:54
@google-cla google-cla bot added the cla: yes label May 17, 2021
ncooke3
ncooke3 approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added a few small comments

FirebaseAppCheck/Sources/AppAttestProvider/Storage/FIRAppAttestArtifactStorage.h
/// @return An artifact that is resolved with the artifact data passed into the method in case of
/// success or is rejected with an error.
- (FBLPromise<NSData *> *)setArtifact:(nullable NSData *)artifact;
- (FBLPromise<NSData *> *)setArtifact:(nullable NSData *)artifact forKey:(NSString *)keyID;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the keyID have the nonnull attribute that is specified in the method's implementation? Does adding it here give any more type/nullability safety? ... I was wondering about this and unsure

Copy link
Contributor Author