Implement API for ExchangeAppAttestAssertionRequest endpoint #8065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ef7c86 to
70cda5f
Compare
| static NSString *const kRequestFieldKeyID = @"key_id"; | ||
| static NSString *const kRequestFieldArtifact = @"artifact"; | ||
| static NSString *const kRequestFieldAssertion = @"assertion"; | ||
| static NSString *const kRequestFieldAttestation = @"attestationStatement"; |
There was a problem hiding this comment.
This is something we will need to double check because the DeviceCheck endpoint accepts snake case field names.
|
|
||
| static NSString *const kExchangeAppAttestAssertionEndpoint = @"exchangeAppAttestAssertion"; | ||
| static NSString *const kExchangeAppAttestAttestationEndpoint = @"exchangeAppAttestAttestation"; | ||
| static NSString *const kGenerateAppAttestChallengeEndpoint = @"generateAppAttestChallenge"; |
| [NSString stringWithFormat:@"%@/projects/%@/apps/%@:generateAppAttestChallenge", | ||
| self.APIService.baseURL, self.projectID, self.appID]; | ||
| NSURL *URL = [NSURL URLWithString:URLString]; | ||
| NSURL *URL = [self URLForEndpoint:kGenerateAppAttestChallengeEndpoint]; |
ncooke3
commented
May 12, 2021
Comment on lines
223
to
229
| - (id)HTTPBodyWithJSONObject:(nonnull id)JSONObject { | ||
| NSError *encodingError; | ||
| NSData *payloadJSON = [NSJSONSerialization dataWithJSONObject:JSONObject | ||
| options:0 | ||
| error:&encodingError]; | ||
| return payloadJSON ?: [FIRAppCheckErrorUtil JSONSerializationError:encodingError]; | ||
| } |
There was a problem hiding this comment.
Added this helper to hopefully consolidate the class's JSON serialization logic. WDYT? Returning id to allow for either NSData or NSError but could instead return a promise that has been fulfilled/rejected...
There was a problem hiding this comment.
A fulfilled/rejected promise looks like a much more readable option to me.
maksymmalyhin
approved these changes
May 13, 2021
Comment on lines
223
to
229
| - (id)HTTPBodyWithJSONObject:(nonnull id)JSONObject { | ||
| NSError *encodingError; | ||
| NSData *payloadJSON = [NSJSONSerialization dataWithJSONObject:JSONObject | ||
| options:0 | ||
| error:&encodingError]; | ||
| return payloadJSON ?: [FIRAppCheckErrorUtil JSONSerializationError:encodingError]; | ||
| } |
There was a problem hiding this comment.
A fulfilled/rejected promise looks like a much more readable option to me.
| body:HTTPBody | ||
| additionalHeaders:@{kContentTypeKey : kJSONContentType}]; | ||
| }) | ||
| // TODO: Move to default queue. |
There was a problem hiding this comment.
b/187427651
TODO:
#no-changelog