Skip to content

Implement App Attest getRandomChallenge #8033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 6, 2021
Merged

Implement App Attest getRandomChallenge #8033

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
48728b5
Initial implementation
ncooke3 May 4, 2021
77317fa
Parse response body for challenge and stub test cases
ncooke3 May 5, 2021
eefcbbc
Review [Draft]
ncooke3 May 5, 2021
69eb00d
Avoid encoding challenge again
ncooke3 May 5, 2021
6afc05f
Add tests
ncooke3 May 5, 2021
14ebd41
Revert "Avoid encoding challenge again" and add TODO
ncooke3 May 5, 2021
db91ab6
Document tests; Add test
ncooke3 May 5, 2021
3703360
Tests: Add URL validation check
ncooke3 May 6, 2021
14c0672
Review
ncooke3 May 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Review [Draft]
  • Loading branch information
@ncooke3
ncooke3 committed May 5, 2021
commit eefcbbc0537862867ce3ebddb8b9aea84d992d1e
22 changes: 3 additions & 19 deletions FirebaseAppCheck/Sources/AppAttestProvider/API/FIRAppAttestAPIService.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ - (instancetype)initWithAPIService:(id<FIRAppCheckAPIServiceProtocol>)APIService
});
}

#pragma mark - Helpers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: Seems we can be more specific here, e.g. #pragma mark - Challenge response parsing


- (FBLPromise<NSData *> *)randomChallengeWithAPIResponse:(GULURLSessionDataResponse *)response {
return [FBLPromise onQueue:[self defaultQueue] do:^id _Nullable{
NSError *error;
Expand Down Expand Up @@ -112,25 +114,7 @@ - (NSData *)randomChallengeFromResponseBody:(NSData *)response
return nil;
}

NSString *timeToLiveString = responseDict[@"ttl"];
if (![challenge isKindOfClass:[NSString class]] || challenge.length <= 0) {
FIRAppCheckSetErrorToPointer(
[FIRAppCheckErrorUtil appCheckTokenResponseErrorWithMissingField:@"ttl"], outError);
return nil;
}

// Expect a string like "3600s" representing a time interval in seconds.
NSString *timeToLiveValueString = [timeToLiveString stringByReplacingOccurrencesOfString:@"s"
withString:@""];
NSTimeInterval secondsToLive = timeToLiveValueString.doubleValue;

if (secondsToLive == 0) {
FIRAppCheckSetErrorToPointer(
[FIRAppCheckErrorUtil appCheckTokenResponseErrorWithMissingField:@"ttl"], outError);
return nil;
}

NSData *randomChallenge = [challenge dataUsingEncoding:NSUTF8StringEncoding];
NSData *randomChallenge = [[NSData alloc] initWithBase64EncodedString:challenge options:0];
return randomChallenge;
}

Expand Down