Skip to content

Integrate App Check with Firebase umbrella pod #7937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 22, 2021
Merged

Integrate App Check with Firebase umbrella pod #7937

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4766811
App Check: add to Firebase pod
maksymmalyhin Apr 22, 2021
16d90ff
Dangerfile: add App Check
maksymmalyhin Apr 22, 2021
737b95e
Add App Check to Firebase.h
maksymmalyhin Apr 22, 2021
285d8b2
Add App Check to FirebaseManifest.swift
maksymmalyhin Apr 22, 2021
3fe7876
AppCheck: use Firebase version
maksymmalyhin Apr 22, 2021
773d560
style
maksymmalyhin Apr 22, 2021
9e934b9
Fix App Check swift tests for --use-libraries
maksymmalyhin Apr 22, 2021
1aa1fd1
Fix copyright
maksymmalyhin Apr 22, 2021
19dacd6
Revert unecessary changes
maksymmalyhin Apr 22, 2021
7240f45
Disable tests on CI for pod lib lint with --use-libraries and --use-m…
maksymmalyhin Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style
  • Loading branch information
@maksymmalyhin
maksymmalyhin committed Apr 22, 2021
commit 773d56036319408a9d4abae4197ed2f89647070c
2 changes: 1 addition & 1 deletion FirebaseAppCheck/Sources/Core/APIService/FIRAppCheckAPIService.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ - (instancetype)initWithURLSession:(NSURLSession *)session
[request setValue:self.APIKey forHTTPHeaderField:kAPIKeyHeaderKey];

NSString *versionHeader =
[NSString stringWithFormat:@"fire-app-check/%@", FIRFirebaseVersion()];
[NSString stringWithFormat:@"fire-app-check/%@", FIRFirebaseVersion()];
[request setValue:versionHeader forHTTPHeaderField:kUserAgentKey];
// TODO: Uncomment to re-enable platform logging once approved.
// User agent header.
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAppCheck/Tests/Unit/Core/FIRAppCheckAPIServiceTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ - (void)testDataRequestSuccess {

// TODO: Replace the assertions by the commented below once platform logging approved.
NSString *appCheckVersionHeader =
[NSString stringWithFormat:@"fire-app-check/%@", FIRFirebaseVersion()];
[NSString stringWithFormat:@"fire-app-check/%@", FIRFirebaseVersion()];
XCTAssertEqualObjects(request.allHTTPHeaderFields[@"x-firebase-client"], appCheckVersionHeader);
XCTAssertNil(request.allHTTPHeaderFields[@"X-firebase-client-log-type"]);
// XCTAssertEqualObjects(request.allHTTPHeaderFields[@"x-firebase-client"],
Expand Down