Skip to content

Enabling watchOS unit test #7480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 12, 2021
Merged

Enabling watchOS unit test #7480

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cdf0362
add watchos to test in podspec;
charlotteliang Feb 4, 2021
2667846
try enabling watchos unit test
charlotteliang Feb 8, 2021
1e62d74
cleanup podspec
charlotteliang Feb 8, 2021
3a8c9d7
update yml files
charlotteliang Feb 9, 2021
352d5b6
revert changes are not for this PR
charlotteliang Feb 9, 2021
ea673fb
fixed an issue in storage size check when enabling watchOS test
charlotteliang Feb 9, 2021
c9ce565
Merge branch 'master' into fm-watch-unit-test
charlotteliang Feb 9, 2021
69dac7d
clang format
charlotteliang Feb 9, 2021
f79b29f
try adding watchOS in spm workflow
charlotteliang Feb 10, 2021
61f3948
duplicate message check should be enabled for watchOS
charlotteliang Feb 11, 2021
873a3bd
Merge branch 'master' of github.com:firebase/firebase-ios-sdk into fm…
charlotteliang Feb 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
duplicate message check should be enabled for watchOS
  • Loading branch information
@charlotteliang
charlotteliang committed Feb 11, 2021
commit 61f3948ca07e270b9ea6792180c6b2f594279301
1 change: 1 addition & 0 deletions FirebaseMessaging/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# unreleased
- [fixed] Fixed an issue that when checking storage size before writing to the disk, the client was checking the document folder that is no longer used. (#7480)

# 2021-02 -- v7.6.0
Expand Down
3 changes: 0 additions & 3 deletions FirebaseMessaging/Sources/FIRMessaging.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,6 @@ - (void)start {
[self setupNotificationListeners];
[self setupTopics];

#if !TARGET_OS_WATCH
// Print the library version for logging.
NSString *currentLibraryVersion = FIRFirebaseVersion();
FIRMessagingLoggerInfo(kFIRMessagingMessageCodeMessagingPrintLibraryVersion,
Expand All @@ -245,8 +244,6 @@ - (void)start {
// setup FIRMessaging objects
[self setupRmqManager];
[self setupSyncMessageManager];

#endif
}

- (void)setupFileManagerSubDirectory {
Expand Down