Skip to content

Cleanup imports and isEqual #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 22, 2018
Merged

Cleanup imports and isEqual #685

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9731057
Fix headers
wilhuff Jan 19, 2018
e1ba384
Fix isEqual verbosity
wilhuff Jan 19, 2018
89192d9
Fix isEqual for nullable properties
wilhuff Jan 19, 2018
cbeab13
Fix nullability on FSTTestDocSnapshot
wilhuff Jan 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix headers
  • Loading branch information
@wilhuff
wilhuff committed Jan 19, 2018
commit 9731057327427ce27ff7aabddbc62dafe14ebcd2
4 changes: 2 additions & 2 deletions Firestore/Example/Tests/API/FIRCollectionReferenceTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
* limitations under the License.
*/

#import <XCTest/XCTest.h>
#import <FirebaseFirestore/FIRCollectionReference.h>

#import "FirebaseFirestore/FIRCollectionReference.h"
#import <XCTest/XCTest.h>

#import "Firestore/Example/Tests/API/FSTAPIHelpers.h"

Expand Down
4 changes: 2 additions & 2 deletions Firestore/Example/Tests/API/FIRDocumentReferenceTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
* limitations under the License.
*/

#import <XCTest/XCTest.h>
#import <FirebaseFirestore/FIRDocumentReference.h>

#import "FirebaseFirestore/FIRDocumentReference.h"
#import <XCTest/XCTest.h>

#import "Firestore/Example/Tests/API/FSTAPIHelpers.h"

Expand Down
4 changes: 2 additions & 2 deletions Firestore/Example/Tests/API/FIRDocumentSnapshotTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
* limitations under the License.
*/

#import <XCTest/XCTest.h>
#import <FirebaseFirestore/FIRDocumentSnapshot.h>

#import "FirebaseFirestore/FIRDocumentSnapshot.h"
#import <XCTest/XCTest.h>

#import "Firestore/Example/Tests/API/FSTAPIHelpers.h"

Expand Down
3 changes: 2 additions & 1 deletion Firestore/Example/Tests/API/FIRFieldPathTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@
* limitations under the License.
*/

#import <FirebaseFirestore/FIRFieldPath.h>

#import <XCTest/XCTest.h>

#import "FirebaseFirestore/FIRFieldPath.h"
#import "Firestore/Source/API/FIRFieldPath+Internal.h"
#import "Firestore/Source/Model/FSTPath.h"

Expand Down
4 changes: 1 addition & 3 deletions Firestore/Example/Tests/API/FIRFieldValueTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,10 @@
* limitations under the License.
*/

@import FirebaseFirestore;
#import <FirebaseFirestore/FIRFieldValue.h>

#import <XCTest/XCTest.h>

#import "FirebaseFirestore/FIRFieldValue.h"

NS_ASSUME_NONNULL_BEGIN

@interface FIRFieldValueTests : XCTestCase
Expand Down
2 changes: 1 addition & 1 deletion Firestore/Example/Tests/API/FIRGeoPointTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

#import "FirebaseFirestore/FIRGeoPoint.h"
#import <FirebaseFirestore/FIRGeoPoint.h>

#import <XCTest/XCTest.h>

Expand Down
3 changes: 2 additions & 1 deletion Firestore/Example/Tests/API/FIRQuerySnapshotTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@
* limitations under the License.
*/

#import <FirebaseFirestore/FIRQuerySnapshot.h>

#import <XCTest/XCTest.h>

#import "FirebaseFirestore/FIRQuerySnapshot.h"
#import "Firestore/Source/Model/FSTPath.h"

#import "Firestore/Example/Tests/API/FSTAPIHelpers.h"
Expand Down
3 changes: 2 additions & 1 deletion Firestore/Example/Tests/API/FIRQueryTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@
* limitations under the License.
*/

#import <FirebaseFirestore/FIRQuery.h>

#import <XCTest/XCTest.h>

#import "FirebaseFirestore/FIRQuery.h"
#import "Firestore/Source/API/FIRQuery+Internal.h"
#import "Firestore/Source/Core/FSTQuery.h"
#import "Firestore/Source/Model/FSTPath.h"
Expand Down
3 changes: 2 additions & 1 deletion Firestore/Example/Tests/API/FIRSnapshotMetadataTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@
* limitations under the License.
*/

#import <FirebaseFirestore/FIRSnapshotMetadata.h>

#import <XCTest/XCTest.h>

#import "FirebaseFirestore/FIRSnapshotMetadata.h"
#import "Firestore/Source/API/FIRSnapshotMetadata+Internal.h"

NS_ASSUME_NONNULL_BEGIN
Expand Down
11 changes: 6 additions & 5 deletions Firestore/Example/Tests/API/FSTAPIHelpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,14 @@

#import <Foundation/Foundation.h>

#import "FirebaseFirestore/FIRCollectionReference.h"
#import "FirebaseFirestore/FIRDocumentSnapshot.h"
#import "FirebaseFirestore/FIRFirestore.h"
#import "FirebaseFirestore/FIRQuerySnapshot.h"

#import "Firestore/Example/Tests/Util/FSTHelpers.h"

@class FIRCollectionReference;
@class FIRDocumentReference;
@class FIRDocumentSnapshot;
@class FIRFirestore;
@class FIRQuerySnapshot;

NS_ASSUME_NONNULL_BEGIN

#if __cplusplus
Expand Down
6 changes: 4 additions & 2 deletions Firestore/Example/Tests/API/FSTAPIHelpers.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@

#import "Firestore/Example/Tests/API/FSTAPIHelpers.h"

#import "FirebaseFirestore/FIRDocumentReference.h"
#import "FirebaseFirestore/FIRSnapshotMetadata.h"
#import <FirebaseFirestore/FIRDocumentChange.h>
#import <FirebaseFirestore/FIRDocumentReference.h>
#import <FirebaseFirestore/FIRSnapshotMetadata.h>

#import "Firestore/Source/API/FIRCollectionReference+Internal.h"
#import "Firestore/Source/API/FIRDocumentReference+Internal.h"
#import "Firestore/Source/API/FIRDocumentSnapshot+Internal.h"
Expand Down
2 changes: 1 addition & 1 deletion Firestore/Example/Tests/Model/FSTFieldValueTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@

#import "Firestore/Source/Model/FSTFieldValue.h"

#import <FirebaseFirestore/FIRGeoPoint.h>
#import <XCTest/XCTest.h>

#import "FirebaseFirestore/FIRGeoPoint.h"
#import "Firestore/Source/API/FIRFirestore+Internal.h"
#import "Firestore/Source/API/FSTUserDataConverter.h"
#import "Firestore/Source/Core/FSTTimestamp.h"
Expand Down
2 changes: 1 addition & 1 deletion Firestore/Example/Tests/Remote/FSTDatastoreTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
* limitations under the License.
*/

#import "FirebaseFirestore/FIRFirestoreErrors.h"
#import "Firestore/Source/Remote/FSTDatastore.h"

#import <FirebaseFirestore/FIRFirestoreErrors.h>
#import <GRPCClient/GRPCCall.h>
#import <XCTest/XCTest.h>

Expand Down
6 changes: 3 additions & 3 deletions Firestore/Example/Tests/Remote/FSTSerializerBetaTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@

#import "Firestore/Source/Remote/FSTSerializerBeta.h"

#import <FirebaseFirestore/FIRFieldPath.h>
#import <FirebaseFirestore/FIRFirestoreErrors.h>
#import <FirebaseFirestore/FIRGeoPoint.h>
#import <GRPCClient/GRPCCall.h>
#import <XCTest/XCTest.h>

#import "FirebaseFirestore/FIRFieldPath.h"
#import "FirebaseFirestore/FIRFirestoreErrors.h"
#import "FirebaseFirestore/FIRGeoPoint.h"
#import "Firestore/Protos/objc/firestore/local/MaybeDocument.pbobjc.h"
#import "Firestore/Protos/objc/firestore/local/Mutation.pbobjc.h"
#import "Firestore/Protos/objc/google/firestore/v1beta1/Common.pbobjc.h"
Expand Down
2 changes: 1 addition & 1 deletion Firestore/Example/Tests/SpecTests/FSTSpecTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@

#import "Firestore/Example/Tests/SpecTests/FSTSpecTests.h"

#import <FirebaseFirestore/FIRFirestoreErrors.h>
#import <GRPCClient/GRPCCall.h>

#import "FirebaseFirestore/FIRFirestoreErrors.h"
#import "Firestore/Source/Auth/FSTUser.h"
#import "Firestore/Source/Core/FSTEventManager.h"
#import "Firestore/Source/Core/FSTQuery.h"
Expand Down
2 changes: 1 addition & 1 deletion Firestore/Example/Tests/SpecTests/FSTSyncEngineTestDriver.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@

#import "Firestore/Example/Tests/SpecTests/FSTSyncEngineTestDriver.h"

#import <FirebaseFirestore/FIRFirestoreErrors.h>
#import <GRPCClient/GRPCCall.h>

#import "FirebaseFirestore/FIRFirestoreErrors.h"
#import "Firestore/Source/Auth/FSTUser.h"
#import "Firestore/Source/Core/FSTEventManager.h"
#import "Firestore/Source/Core/FSTQuery.h"
Expand Down
5 changes: 3 additions & 2 deletions Firestore/Example/Tests/Util/FSTHelpers.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@

#import "Firestore/Example/Tests/Util/FSTHelpers.h"

#import "FirebaseFirestore/FIRFieldPath.h"
#import "FirebaseFirestore/FIRGeoPoint.h"
#import <FirebaseFirestore/FIRFieldPath.h>
#import <FirebaseFirestore/FIRGeoPoint.h>

#import "Firestore/Source/API/FIRFieldPath+Internal.h"
#import "Firestore/Source/API/FSTUserDataConverter.h"
#import "Firestore/Source/Core/FSTQuery.h"
Expand Down
1 change: 1 addition & 0 deletions Firestore/Source/API/FIRDocumentChange+Internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#import "FIRDocumentChange.h"

@class FIRFirestore;
@class FSTViewSnapshot;

NS_ASSUME_NONNULL_BEGIN
Expand Down