Skip to content

Prevent test build errors under Xcode 12.1 #6760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2020
Merged

Prevent test build errors under Xcode 12.1 #6760

merged 1 commit into from
Oct 16, 2020

Conversation

wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Oct 16, 2020

Xcode 12 changed the XCTest assertions to be macros that no longer implicitly depended on self. It seems as if Xcode 12.1 has made -Wunused-lambda-capture part of our default warnings and this breaks Objective-C++ code that lambda captures self only for its implicit use with the XCTest macros.

This isn't common, so just suppress the warning by forcing self to appear used regardless of whether XCTest assertions reference self or not.

@wilhuff
Prevent test build errors under Xcode 12.1
310ef56 
Xcode 12 changed the XCTest assertions to be macros that no longer
implicitly depended on `self`. It seems as if Xcode 12.1 has made
-Wunused-lambda-capture part of our default warnings and this breaks
Objective-C++ code that lambda captures `self` only for its implicit use
with the XCTest macros.

This isn't common, so just suppress the warning by forcing `self` to
appear used regardless of whether XCTest assertions reference `self` or
not.
@wilhuff wilhuff requested a review from var-const October 16, 2020 22:37
@google-cla google-cla bot added the cla: yes label Oct 16, 2020
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@var-const var-const assigned wilhuff and unassigned var-const Oct 16, 2020
@wilhuff wilhuff merged commit db6013c into master Oct 16, 2020
@wilhuff wilhuff deleted the wilhuff/xcode-self branch October 16, 2020 23:27
manjanac added a commit that referenced this pull request Nov 4, 2020
@manjanac @paulb777
@charlotteliang @maksymmalyhin @schmidt-sebastian @granluo @tejasd @ryanwilson @var-const @karenyz @samedson @wilhuff @christibbs @alexsinger @rosalyntan @akivab @diwu-arete @dmandar @ChaoqunCHEN @morganchen12 @schnecle @yuchenshi @daisuke-t-jp @wu-hui @jim-hays-root @samtstern @eldhosembabu @vic-flair @adamvduke
ML master update (#6891)
0d4efa5 
* Restores ML Pods after M77.

* Remove deprecated sendLogsWithServiceName (#6437)

* Remove deprecated pods from Firebase.h and Firebase.podspec (#6438)

* Remove the FCM Direct Channel API from Messaging (#6430)

* Remove unnecessary Core private headers (#6439)

* Update SPM docs to current version (#6524)

* Update podspecs to min iOS 10 (#6517)

* Merging the 6.33.0 release into master (#6523)

* Update versions for Release 6.33.0

* SPM M80(6.33.0) Analytics update (#6490)

Co-authored-by: Paul Beusterien <[email protected]>

* Merge 6.33 SPM fixes back to master (