Support paths with + in List API #6700
Conversation
8610cc6 to
969ba5c
Compare
969ba5c to
e60654e
Compare
| @"o?prefix=%2Bfoo/&delimiter=/"]; | ||
|
|
||
| self.fetcherService.testBlock = | ||
| ^(GTMSessionFetcher *fetcher, GTMSessionFetcherTestResponse response) { |
There was a problem hiding this comment.
Can you avoid the pragma with an approach like #6693?
There was a problem hiding this comment.
I am getting an unused variable warning, and I don't see how the code you linked to doesn't generate the same warning. Is there any trick I need to employ?
| @"o?prefix=%2Bfoo/&delimiter=/"]; | ||
|
|
||
| self.fetcherService.testBlock = | ||
| ^(GTMSessionFetcher *fetcher, GTMSessionFetcherTestResponse response) { |
There was a problem hiding this comment.
I am getting an unused variable warning, and I don't see how the code you linked to doesn't generate the same warning. Is there any trick I need to employ?
|
There's something weird going on with the XCTest macros. In the Messaging test, they reference self but not in the Storage test - I can't see what about the projects would trigger the difference. I also don't reproduce the warning when I remove the #pragma's in the Storage test. This probably isn't worth this much time - so I'm fine to merge as is. |
NSQueryParams doesn't encode
+to%2B, which breaks the List API since it treats+as space.Note that other Storage APIs don't rely on query param encoding. There is already an integration tests that verifies that users can up and download files with
+signs.Fixes b/170259897