Fix FSTLocalDocumentsView to allow multiple mutations while offline #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only the last mutation would actually be visible.
5be0b75 to
e76c78c
Compare
wilhuff
approved these changes
Jan 11, 2018
| @@ -54,6 +54,8 @@ NS_ASSUME_NONNULL_BEGIN | |||
| - (void)shutdownWithCompletion:(nullable void (^)(NSError *_Nullable error))completion | |||
| NS_SWIFT_NAME(shutdown(completion:)); | |||
|
|
|||
| - (instancetype)firestoreWithConfiguredClient; | |||
There was a problem hiding this comment.
This shouldn't be required.
Merged
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
…irebase#644) * Fix FSTLocalDocumentsView to allow multiple mutations while offline. Previously, only the last mutation would actually be visible.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only the last mutation would actually be visible. (Mutations would not actually be discarded, but you wouldn't be able to actually see them until the client came online again.)