Skip to content

Remove deprecated pods from Firebase.h and Firebase.podspec #6438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2020
Merged

Remove deprecated pods from Firebase.h and Firebase.podspec #6438

merged 1 commit into from
Sep 11, 2020

Conversation

paulb777
Copy link
Member

Fix #4900. Fix #6417.

#no-changelog

@paulb777 paulb777 added this to the Firebase 7 milestone Sep 10, 2020
@paulb777 paulb777 requested a review from ryanwilson September 11, 2020 14:10
ryanwilson
ryanwilson requested changes Sep 11, 2020
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the base branch to firebase7-main, then LGTM

@paulb777 paulb777 changed the base branch from master to firebase7-main September 11, 2020 15:26
@paulb777
Copy link
Member Author

Done.

@ryanwilson
Copy link
Member

Thanks!

@paulb777 paulb777 merged commit b893f23 into firebase7-main Sep 11, 2020
@paulb777 paulb777 deleted the pb-deprecatedpods7 branch September 11, 2020 16:15
This was referenced Sep 11, 2020
Closed
Closed
@firebase firebase locked and limited conversation to collaborators Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees

@ryanwilson ryanwilson

Labels
api: core cla: yes
Projects
None yet
Milestone
Firebase 7 - M82
Development

Successfully merging this pull request may close these issues.

Firebase 7: Remove deprecated MLKit pods from umbrella header Remove InAppMessagingDisplay subspec from Firebase pod
4 participants
@paulb777 @ryanwilson @googlebot @google-oss-bot