Add iOS build support to the CMake build #5052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use `version` consistently * Use `firebase_ios_version` for the repo-level version * Remove INCLUDE directories that are no longer needed * Sort dependencies
* Add `OBJC_FLAGS` directly, avoiding a separate `sources` variable. * Add resources directly
This reduces the chance of collision with other projects.
Now that compiler_setup.cmake no longer has side-effects, fold compiler_id.cmake and archive_options.cmake into it and move the include of compiler_setup up to the top of the main build.
This makes it possible to build non-Firestore components in the CMake build to a lower standard than that to which we hold ourselves without sacrificing the utility of the various build rules that we have.
|
Diffbase removed. |
Generated by 🚫 Danger |
a-maurice
reviewed
Mar 11, 2020
a-maurice
approved these changes
Mar 11, 2020
|
Travis failures are unrelated. |
doudounan
pushed a commit
that referenced
this pull request
Mar 19, 2020
* Move UpdateFirebasePod to Swift's ArgumentParser library. (#4993) * Move UpdateFirebasePod to Swift's ArgumentParser library. This was introduced in URL, leaving a nice clean way to provide command line arguments. Example output: ``` $ swift run UpdateFirebasePod Error: Missing expected argument '--git-root <git-root>' Usage: firebase-pod-updater --git-root <git-root> --current-release <current-release> ``` * Removed unnecessary file. * Fixed formatting. * Use existing argument name for currentRelease. * Sorted package dependencies. * Pin to exact version. * Rename UpdateFirebasePod to firebase-pod-updater This sticks with convention expected by the tooling. Future PRs will change the `ReleasePackager` and other tools as well. * Renamed pod updater. (#5003) * Upload Symbols 3.1 (#4988) * Crashlytics Update CHANGELOG.md for v4.0.0-beta.5 (#5004) * Checks for connectivity when App is moving to foreground. (#4985) * Checks for connectivity when App is moving to foreground. * Split MaybeInvokeCallbacks and invoke them when foregrounding and network is available. * Update CHANGELOG for Firestore v1.11.1 (#5008) * Support AB testing of Firebase In-App Messages (#5005) * Parse out experiment payload for experimental FIAMs and store it on FIRIAMMessageDefinition * Fix bugs in parsing experimental payload * Add nullable experiment payload to FIAM message definition. Add method in FIRExperimenmtController to validate running experiments and call this when new messages are fetched from FIAM backend * Add and document new ABT methods, update FirebaseInAppMessaging.podspec to depend on ABT * Clean up deprecated public message initializers, add experiment payload to private initializers * Activate experiment for experimental messages upon impression * Clean up activateExperiment API * Add experimental payload to all message definition initializers * Add unit test coverage for new ABT methods * Add test coverage for parsing experimental messages * Verify experiment payload gets passed to message superclass * Scripts/style.sh * Update Podfile for UI test app to include AB Testing SDK * Add back deprecated initializers for now, these are needed for the test app * Test for non-nil experiment payload * Use mutable array directly, better memory usage * Bump ABTesting podspec version, depend on new ABT in FIAM * Remove mentions of FIREventOrigins.h * Remove experiment payload from public API, hide it in private * Scripts/style.sh * Fix comment indentation, allow for FIAM to depend on minor version updates of ABTesting * Move ABTExperimentPayload import to private header * Core M66 changelog update (#5013) * Core M66 changelog update * Core M65 notes corrected. * FirebaseStorage.podspec - update Core dependency version to one supporting watchOS (#5014) * Update versions for Release 6.19.0 * Add FirebaseABTesting to travis cron tests (#5015) * GoogleDataTransportCCTSupport - bump GoogleDataTransport dependency to ~> 5.0 * FirebaseCoreDiagnostics 1.2.2 - bump GoogleDataTransportCCTSupport dependency to ~> 2.0 (#5016) * M66 FirebaseCoreDiagnostics added to the release manifest (
Individual commits more-or-less say what they're doing.
At a high level, this change:
DISABLE_STRICT_WARNINGSflag and removing the-Wno-fooblocks that were subtracting from the full warnings battery. This is ultimately a better choice for effectively third-party code.Note: