Skip to content

Restore Firestore build in xcframework branch #4995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2020
Merged

Restore Firestore build in xcframework branch #4995

merged 1 commit into from
Mar 2, 2020

Conversation

paulb777
Copy link
Member

Restore Firestore build after #4940 broke it because of the abseil dependency.

With this change, a zip with xcframeworks for all the Podfile dependencies of the Firestore quickstart now build.

The quickstart fails to build because FirebaseUI does not have an umbrella header necessary for Swift module imports. The proper way to build static libs in CocoaPods with modular headers is the use_modular_headers! option but that does now work with Firestore because gRPC does not work with them. See grpc/grpc#20631 and CocoaPods/CocoaPods#9023.

Next step is to investigate the feasibility of fixing CocoaPods/CocoaPods#9023. In the meantime sending the PR here to checkpoint.

Here is the json file for the Firestore quickstart:


[
  {
    "name": "FirebaseFirestore"
  },
   {
    "name": "FirebaseUI/Auth"
  },
   {
    "name": "FirebaseUI/Email"
  },
   {
    "name": "SDWebImage"
  },
   {
    "name": "FirebaseAuth"
  }
]

@paulb777 paulb777 added the zip-builder Tools related to building the zip file. label Feb 29, 2020
@paulb777 paulb777 requested a review from ryanwilson February 29, 2020 00:46
ryanwilson
ryanwilson reviewed Mar 2, 2020
View reviewed changes
ZipBuilder/Sources/ZipBuilder/CocoaPodUtils.swift
fatalError("Multi-layered subspecs are not supported - \(podName)")
} else if subspecArray.count == 1 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this else statement just for abseil before?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abseil was falling into the error case before since it has a two-layered subspec. Now we still error out on two-layer subspecs except for abseil.

@paulb777 paulb777 merged commit b761710 into xcframework-master Mar 2, 2020
@paulb777 paulb777 deleted the pb-build-firestore branch March 2, 2020 15:57
paulb777 added a commit that referenced this pull request Mar 6, 2020
@paulb777
Restore Firestore build (#4995)
f9de20c
paulb777 added a commit that referenced this pull request Mar 13, 2020
@paulb777
Restore Firestore build (#4995)
ab1ecf2
doudounan pushed a commit that referenced this pull request Mar 19, 2020
@ddnan @ryanwilson
@samedson @wu-hui @wilhuff