Skip to content

Crash prevention in FIRCLSNetworkClient #4659

@GUserx

Description

@GUserx
  • Xcode version: Version 11.3 (11C29)
  • Firebase SDK version: deepens on component, not using the full sdk
  • Firebase Component: Crashlytics
  • Component version: Installed via cocoaPods

Hi everyone,
I would like to make a few changes in FIRCLSNetworkClient to make a code a little bit more safety :)
So the changes over here: bbc59fa

I've seen that ReportManager passes nonnull block inside the networkClient but at some day any another client can pass a nil over here.

So may I create a pull request for this changes?
Also, FirebaseCrashlytics-Unit Tests successfully passed :)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions